test: add E2E tests for markdown shortcuts in editor (#224)#231
Merged
Conversation
Co-authored-by: Ona <no-reply@ona.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
Author
|
✅ UI verification skipped — no UI files changed. This PR only adds E2E tests ( |
Collaborator
Author
|
✅ Post-merge verification skipped — |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #224
What
Adds E2E Playwright tests verifying that Lexical's
MarkdownShortcutPlugincorrectly transforms markdown syntax as the user types in the editor.Tests added
#at line start<h1>>at line start<blockquote>-at line start<ul><li>```+ Space<code>blockEach test creates a fresh page via
navigateToEditorPage, types the markdown shortcut, then asserts the DOM element type changed and typed content renders inside the new block.How
editor-slash-commands.spec.tsandeditor-toolbar.spec.tsauthenticatedPagefixture andnavigateToEditorPagehelperDate.now()markers to avoid matching pre-existing contentTesting
pnpm lint✅pnpm typecheck✅pnpm test— 252 unit tests pass ✅pnpm test:e2e— 66 E2E tests pass (including 4 new) ✅