Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[initial commit] yugabytedb dedicated base image #604

Merged
merged 7 commits into from Mar 10, 2022
Merged

[initial commit] yugabytedb dedicated base image #604

merged 7 commits into from Mar 10, 2022

Conversation

srinivasa-vasu
Copy link
Contributor

@srinivasa-vasu srinivasa-vasu commented Dec 27, 2021 •
edited by kylos101

Description

The dedicated base image for yugabytedb

Related Issue(s)

Fixes #737

Release Notes

NONE

@gitpod-io
Copy link

gitpod-io bot commented Dec 27, 2021

@aledbf
Copy link
Member

aledbf commented Dec 28, 2021

@srinivasa-vasu thank you for your contribution. At this moment, we are revamping the build process of the images.
For that reason, we are not introducing new features/images or changes. Once we finish, we will review your pull request.
Apologies for the inconvenience.

@princerachit
Copy link
Contributor

Hi @srinivasa-vasu , can you create an issue to discuss this? We have moved to a new way of managing workspace-images, please refer to the Contributors guide to learn more.

@srinivasa-vasu srinivasa-vasu mentioned this pull request Feb 28, 2022
Closed
@kylos101 kylos101 reopened this Mar 7, 2022
@gitpod-staging
Copy link

gitpod-staging bot commented Mar 7, 2022

@kylos101 kylos101 marked this pull request as draft March 7, 2022 02:37
@kylos101
Copy link
Collaborator

kylos101 commented Mar 7, 2022

Hi @srinivasa-vasu , I've reopened this PR and set it to draft as per this feedback. Let us know if you have any questions or trouble with the corresponding updates? Also, once you're feeling good about the PR, you're welcome to mark it as ready for review.

@srinivasa-vasu
Copy link
Contributor Author

@kylos101 - sure, will do that. Thanks.

@srinivasa-vasu srinivasa-vasu force-pushed the yugabytedb branch 2 times, most recently from 8530cf5 to dde96ef Compare March 7, 2022 08:31
@srinivasa-vasu srinivasa-vasu marked this pull request as ready for review March 7, 2022 08:35
@srinivasa-vasu srinivasa-vasu requested a review from a team March 7, 2022 08:35
utam0k
utam0k reviewed Mar 8, 2022
View reviewed changes
Copy link
Contributor

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR. I left a comment.

chunks/tool-yugabytedb/Dockerfile Outdated Show resolved Hide resolved
utam0k
utam0k reviewed Mar 8, 2022
View reviewed changes
Copy link
Contributor

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments to pass the CI. Please check.

tests/tool-yugabytedb.yaml Outdated Show resolved Hide resolved
tests/tool-yugabytedb.yaml Outdated Show resolved Hide resolved
chunks/tool-yugabytedb/Dockerfile Outdated Show resolved Hide resolved
chunks/tool-yugabytedb/Dockerfile Outdated Show resolved Hide resolved
@srinivasa-vasu
yugabytedb base image- initial commit
5552c06 
Signed-off-by: Srinivasa Vasu <srinivasan.surprise@gmail.com>
@srinivasa-vasu
optimized to minimize the image creation time
f728473 
Signed-off-by: Srinivasa Vasu <srinivasan.surprise@gmail.com>
@srinivasa-vasu
update yugabytedb based on dazzle-v2
981f94c
@srinivasa-vasu
remove - yugabytedb earlier versioned files
52ef30f 
Signed-off-by: Srinivasa Vasu <srinivasan.surprise@gmail.com>
@srinivasa-vasu
update test file chunk
a09ffda 
Signed-off-by: Srinivasa Vasu <srinivasan.surprise@gmail.com>
@srinivasa-vasu
add new line for the CI run
c30a2a9 
Signed-off-by: Srinivasa Vasu <srinivasan.surprise@gmail.com>
@srinivasa-vasu
update cosmetic
5882116 
Signed-off-by: Srinivasa Vasu <srinivasan.surprise@gmail.com>
utam0k
utam0k approved these changes Mar 10, 2022
View reviewed changes
Copy link
Contributor

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@utam0k
Copy link
Contributor

utam0k commented Mar 10, 2022

@srinivasa-vasu Thanks for your contribution.

@utam0k utam0k merged commit 9bde118 into gitpod-io:main Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utam0k utam0k utam0k approved these changes

Assignees
No one assigned
Labels
team: workspace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

yugabytedb dedicated workspace-images (base image)
5 participants
@srinivasa-vasu @aledbf @princerachit @kylos101 @utam0k