New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow scrolling in MD code #651

Open
embiem opened this Issue Dec 1, 2017 · 4 comments

Comments

Projects
3 participants
@embiem

embiem commented Dec 1, 2017

When I want to scroll a code example in MD in any readme to left or right, the app actually tries to switch e.g. from home area to notification area.

Expected:
When tapping first inside a code example in MD, hold the tap and move, then I'd expect that the actual embedded code preview is scrolled.

I'd like to tackle this issue myself as a first contribution, if you agree that this is an issue that needs to be fixed.

@chinesedfan

This comment has been minimized.

Show comment
Hide comment
@chinesedfan

chinesedfan Dec 1, 2017

Member

@mBeierl Sure. Welcome to GitPoint!

But I didn't re-produce this problem when visiting readme of my project (iPhone 6P, iOS 11.1, GitPoint 1.3). Can you provide your test project, app version and device information?

Member

chinesedfan commented Dec 1, 2017

@mBeierl Sure. Welcome to GitPoint!

But I didn't re-produce this problem when visiting readme of my project (iPhone 6P, iOS 11.1, GitPoint 1.3). Can you provide your test project, app version and device information?

@machour

This comment has been minimized.

Show comment
Hide comment
@machour

machour Dec 1, 2017

Member

Confirmed on Android, as soon as you try to scroll a <code> block, react-navigation swipe kicks in and wants to switch tabs:

screenshot_1512140541

Member

machour commented Dec 1, 2017

Confirmed on Android, as soon as you try to scroll a <code> block, react-navigation swipe kicks in and wants to switch tabs:

screenshot_1512140541

@machour

This comment has been minimized.

Show comment
Hide comment
@machour

machour Dec 1, 2017

Member

@mBeierl Thank you a lot for logging this issue! I remember we talked about in #326 (comment)

We'll be more than glad if you can give this issue a fresher look!

Member

machour commented Dec 1, 2017

@mBeierl Thank you a lot for logging this issue! I remember we talked about in #326 (comment)

We'll be more than glad if you can give this issue a fresher look!

@housseindjirdeh housseindjirdeh added this to To Do in v1.5.0 Dec 19, 2017

@machour

This comment has been minimized.

Show comment
Hide comment
@machour

machour Dec 20, 2017

Member

Seems like react-native-navigation latest version allow disabling the swipe gesture for a particular screen.
Could that be an acceptable fix for markdown enabled screen on Android @housseindjirdeh ?
react-navigation/react-navigation#2906

Member

machour commented Dec 20, 2017

Seems like react-native-navigation latest version allow disabling the swipe gesture for a particular screen.
Could that be an acceptable fix for markdown enabled screen on Android @housseindjirdeh ?
react-navigation/react-navigation#2906

@machour machour added this to Todo in 1.6.0 Feb 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment