-
Notifications
You must be signed in to change notification settings - Fork 791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(badge): fix weird badge styling #587
Conversation
@t-howell can you please upload a screenshot of the end result? Thanks! |
Thank you @t-howell <3 And no worries at all matey! We'll squash them anyway as we merge them in. Seconding @alejandronanez and could you please upload a before and after screenshot when you get the chance? |
Hey, also the text color should be white, that was removed after the refactor to style components :/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seconding what @jouderianjr mentioned, when you get the chance to change the text color to white this should be good to go 🙏
@@ -14,7 +14,7 @@ const BadgeContainer = styled.View` | |||
flex: 1; | |||
align-items: center; | |||
justify-content: center; | |||
border-radius: 18; | |||
border-radius: 25; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
normally, in order to have a circle, the border-radius should be equal to width & height.
could you provide a screenshot of the result?
don't hesitate if you need any assistance with this PR!
@t-howell I looked at the badge again this morning and I didn't notice the weird borders anymore. I guess this was somehow fixed by upgrading to latest react-native-version. 🤔 Could you rollback the Let me know if you need any assistance. 🙏 |
Hey all, sorry for the late reply! I didn't expect to hear back on this one, honestly. This was my first go at contributing to a project - I'm a newb. I couldn't get the environment running, so this was just my best guess. What do you mean by "rollback"? I can definitely make the text white. |
@t-howell Thank you for your honesty and no worries mate! We all had to start somewhere 😉 To rollback something is to cancel the changes made (as opposed to roll out a new feature I guess) We do however require you to provide a screenshot in your PR, so you will need to get the project running on your side. If you're planning to do more react/react-native development in the future, that could be a good occasion to get you started. Do you want to go over our setup instructions and try to do that? We're available on gitter if you get stuck somewhere. |
@t-howell are you still up for this? We need to fix this bug for the upcoming 1.4 release 🙏 |
Would you take care of it? I'd love help figuring out this React thing when things are less busy! Thanks for your understanding. |
Attempting to help with issue #581 - Sorry about the commit message format, it was my first try at angular formatting, I'll have to practice