Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
CatFileContentStream.execute() should probably safe_decode() stdout and stderr #470
Comments
added a commit
to warsaw/GitPython
that referenced
this issue
Jun 15, 2016
Byron
closed this
in
#475
Jun 20, 2016
added a commit
that referenced
this issue
Jun 20, 2016
Byron
added
the
acknowledged
label
Jun 20, 2016
Byron
added this to the v2.0.6 - Bugfixes milestone
Jun 20, 2016
pushed a commit
to yarikoptic/GitPython
that referenced
this issue
Sep 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
warsaw commentedJun 13, 2016
•
Edited 1 time
-
warsaw
Jun 13, 2016
FTR, using Python 3.5 here.
In a Debian project, we want to essentially
git show <ref>:debian/changelogbut the changelog has some bogus non-utf-8 characters in it. Here's an excerpt (not sure if this will come through in the GH issue):However, the command tracebacks (notice the weird
<F6>in the changelog entry).where
defencis utf-8. Since git/compat.py already has asafe_decode()method, that should probably be used instead onstdout_valueandstderr_valueto ensure you don't get an exception on bogus data.