From c4ded5625360f885fd107a0abe434706c704f671 Mon Sep 17 00:00:00 2001 From: Paul Kramme Date: Fri, 8 Jul 2016 12:51:04 -0400 Subject: [PATCH] Add PR Section to CONTRIBUTING.md (#491) * Update CONTRIBUTING.md * Update CONTRIBUTING.md --- CONTRIBUTING.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 5df27617..315a18a0 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -34,3 +34,7 @@ and are better then 'this thing there is broken. go fix it'. It also helps if yo This is the place to disguss. Don't get angry if someone don't share your opinion, rather try to convince him while staying friendly. This is the most important thing: If your unfriendly no matter your skill level, no one will respect you. Always remember that you're the one who wants something. ### Reactions Software projects are mostly driven by community feedpack and ideas, so if you read another issue that wants to add a feature, react to it by writing something like "I like / don't like it" or by using the emoticons to show the creators what you want. This is the most valuable feedpack a developer can have. +## Pull Requests +In order to create a Pull Request, you have to create a fork first. To obtain infos about how to get your fork working check out [this](https://github.com/gitskarios/Gitskarios/blob/develop/FORK.md). If you still have problems getting your branch working, create an issue explaining what your problem is. +When you're about creating a pull request, you have to name it after it contains, for example: You created feature X, then name it after this feature. You created a fix for a issue, name it 'Fix #tag-of-the-issue' so everyone knows what you were doing. +**KEEP IN MIND THAT PULL REQUEST WITH A BASE BRANCH OF 'MASTER' OR 'DEVELOP' WILL NOT BE ACCEPTED. CREATE ONE BRANCH FOR ONE FIX OR FEATURE. ALSO KEEP IN MIND THAT THE BRANCH NAME HAS TO REPRESENTATE THE CHANGES IT CONTAINS.**