Skip to content

Remove Vuex from commit information #43

@mittalyashu

Description

@mittalyashu

Description

In commitInformation.vue file, we are committing mutations and storing data inside Vuex store and later fetching the data from the same file to print it to the DOM.

Should we keeping Vuex for commitInformation.vue or just use local data property.

For example

    getAuthorDetail(hash) {
    			const params = [hash, "--format=%an %n %ae %n %ad"];
    			showMixin(this.currentRepository, params).then(result => {
    				let output = result.split("\n");
    				this.$store.dispatch({
    					type: "history/updateCommitInformationAuthor",
    					author_name: output[0].trim(),
    					author_email: output[1].trim(),
    					author_date: output[2].trim()
    				});
    			});
    		}

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions