Fix crash and miscellaneous cleanup #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jspiro
approved these changes
Apr 26, 2021
|
I'm actually wondering why our CI is not building. Do you think you could check the .github folder and see if you can convince this to do a build with your changes? |
jspiro
requested changes
Apr 26, 2021
|
I am just lurking here, but this may be helpful https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks |
|
Aha! That's annoying. I guess it makes sense...ish. Lemme see what I can do. |
…ally use PBGitRepository
…only need it at the end of the method
Reference the repository and windowController proeprties instead
|
Fixed, thanks. Got a little too aggressive with committing Apple silicon support :) |
jspiro
approved these changes
Apr 27, 2021
|
Thank you for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a crash introduced by bb8a516 and does some incremental cleanup that I performed while looking for the crash (remove unnecessary passing of PBGitRepository in arguments and removed instance variables marked with a FIXME).