New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crash and miscellaneous cleanup #223
Conversation
I'm actually wondering why our CI is not building. Do you think you could check the .github folder and see if you can convince this to do a build with your changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please try to get CI working on this build before we merge it.
I am just lurking here, but this may be helpful https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks |
Aha! That's annoying. I guess it makes sense...ish. Lemme see what I can do. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a linker error.
…ally use PBGitRepository
…only need it at the end of the method
Reference the repository and windowController proeprties instead
Fixed, thanks. Got a little too aggressive with committing Apple silicon support :) |
Thank you for the contribution! |
Fixes a crash introduced by bb8a516 and does some incremental cleanup that I performed while looking for the crash (remove unnecessary passing of PBGitRepository in arguments and removed instance variables marked with a FIXME).