Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use TLS 1.2 for github api #3

Merged
merged 1 commit into from Feb 26, 2018

Conversation

@petersendev
Copy link
Contributor

commented Feb 25, 2018

Fixes #2

Use TLS 1.2 for github api
GitHub requires TLS 1.2 since Feb 22 2018, see https://githubengineering.com/crypto-removal-notice/
@giuliov

This comment has been minimized.

Copy link
Owner

commented Feb 26, 2018

Thanks for the PR, exactly the kind of solution I imagined. I saw the news but didn't realize it might impact my code 😳

@giuliov giuliov merged commit c85d1fb into giuliov:master Feb 26, 2018

@petersendev petersendev deleted the petersendev:github-tls12 branch Mar 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.