Certain grades not appearing in gradebook #780

Closed
mpenguin opened this Issue Oct 19, 2016 · 21 comments

Projects

None yet

3 participants

@mpenguin

Currently using the most recent Moodle 3.1 and the most recent Essential theme (default colors; no changes).

I've found that some items in the gradebook don't appear; their CSS appears to make them transparent. It is only when highlighting with the mouse that I can see them (the default orange highlighting by the Essential theme does not reveal them). I've included two screenshots - one without mouse highlighting and one with mouse highlighting to show you that every other max grade is not visible in the gradebook setup.

no highlighting

highlighting

Since I'm running the Essential theme with the default colors, this appears to be a bug in the theme. Anything that I can change in order to make these max grades appear again?

@gjb2048
Owner
gjb2048 commented Oct 19, 2016
@mpenguin

Moodle 3.1.2 (Build: 20160912)
Essential 3.1.1.2 (Build: 2016061711)

@gjb2048 gjb2048 self-assigned this Oct 19, 2016
@gjb2048
Owner
gjb2048 commented Oct 19, 2016

Took longer to find as 'Grade: Setup: Gradebook setup'.

@gjb2048
Owner
gjb2048 commented Oct 19, 2016

Down to '.leveleven' class. Almost certainly need to fix 2.9 -> 3.1.

@gjb2048
Owner
gjb2048 commented Oct 19, 2016

No easy solution to this. Need to think.

@lazydaisy

I think this is the same problem.
https://moodle.org/mod/forum/discuss.php?d=341865
Looks to be load of HOVER specific CSS being generated in Essential for the gradebook.

@gjb2048
Owner
gjb2048 commented Oct 23, 2016

It is.

@gjb2048
Owner
gjb2048 commented Oct 23, 2016

But rather that the gradebook is styling things at a very specific level. This is why Moodle needs a design, a set of re-usable styles that are used everywhere for the same sort of thing. Then any theme could change them once and be happy that they were changed everywhere. Thus, tables styled by one set of selectors, rather than the mess we have now with every single grain of sand being styled.

@gjb2048
Owner
gjb2048 commented Oct 23, 2016

Oh no, levels! This contradicts the striping. Muppets!

@lazydaisy

Indeed!

@gjb2048 gjb2048 closed this in 14ac6d8 Oct 23, 2016
@gjb2048 gjb2048 reopened this Oct 23, 2016
@gjb2048 gjb2048 closed this Nov 15, 2016
@gjb2048 gjb2048 reopened this Nov 16, 2016
@gjb2048
Owner
gjb2048 commented Nov 16, 2016

Grrr, still an issue.

@gjb2048
Owner
gjb2048 commented Nov 16, 2016

M3.1 only issue still.

@mpenguin

I purged all caches; Running in the latest Moodle 3.1.3 and latest Essential 3.1.13 (see pics below).

It appears that the "hidden" numbers are now white, which makes them barely stand out, but still not easily visible. Any other information I could provide to help?

2016-11-16 20_12_00-twu dafl moodle_ administration_ notifications
2016-11-16 20_12_48-twu dafl moodle_ administration_ plugins_ plugins overview
2016-11-16 20_10_31-grades_ setup
2016-11-16 20_10_56-grades_ setup

@gjb2048
Owner
gjb2048 commented Nov 16, 2016

Thanks @mpenguin - so complicated! All to do with specific styling in the grade CSS that I have to undo / redo because of the Essential hover / table styling and attempts by me to be generic.

@gjb2048
Owner
gjb2048 commented Nov 16, 2016

I do have a plan!

@gjb2048
Owner
gjb2048 commented Nov 16, 2016

Still can't work out why the changes I made by adding 'grade.less' for the settings: 14ac6d8 worked and now don't work.

@gjb2048
Owner
gjb2048 commented Nov 16, 2016

Ok, two things going on here, fixed 'Grade: View: User report' but not '
Grade: Setup: Gradebook setup'.

@gjb2048
Owner
gjb2048 commented Nov 16, 2016

@mpenguin - Please could you test: cc92b6b.

@mpenguin

@gjb2048 Yes, that is working! Looks great!
Thanks for your hard work in fixing this issue!

@gjb2048
Owner
gjb2048 commented Nov 17, 2016

Thank you @mpenguin - I'm going to release 3.1.1.4 shortly.

@gjb2048
Owner
gjb2048 commented Nov 27, 2016

Fixed.

@gjb2048 gjb2048 closed this Nov 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment