From cafc76509b678539299d1c34c41fd1cb75e68cd7 Mon Sep 17 00:00:00 2001 From: Pascal Garber Date: Mon, 29 Jun 2026 14:04:04 +0200 Subject: [PATCH] fix: allow void return from connect callback MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit SignalMethods.connect typed its callback return as `boolean | undefined`, which rejected the common case of a handler that returns nothing — a void-returning function is not assignable to `boolean | undefined`. Use `boolean | void` so handlers may return nothing or `true` to stop emission, matching imports.signals semantics (only `true` stops emission). Closes #116 --- packages/gnome-shell/src/misc/signals.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/gnome-shell/src/misc/signals.d.ts b/packages/gnome-shell/src/misc/signals.d.ts index 09e6183..674527c 100644 --- a/packages/gnome-shell/src/misc/signals.d.ts +++ b/packages/gnome-shell/src/misc/signals.d.ts @@ -41,7 +41,7 @@ export interface SignalMethods = any> { * @param callback A callback function * @returns A handler ID */ - connect(sigName: Name, callback: (self: this, ...args: S[Name]) => boolean | undefined): number; + connect(sigName: Name, callback: (self: this, ...args: S[Name]) => boolean | void): number; /** * Emits a signal for an object. Emission stops if a signal handler returns `true`. *