New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix fillAddress() crash and support mutli-byte characters on query #3

Merged
merged 1 commit into from Mar 26, 2015

Conversation

Projects
None yet
6 participants
@wildtree
Contributor

wildtree commented Nov 1, 2014

Hi gkoo,

I faced crashing 'map me' on hubot, because of missing fillAddress() function,
I cannot find which module I should install to fix it, so simply remove it,
on the other hand, I found that I cannot get any maps if I asked location by Japanese characters, we need URI encoding for these query.

so, I also put it instead of escape(),

it is great if you pull this or fixed these issues in your way,

Thank you,

  • remove fillAddress() due to missing it.
  • use 'encodeURIComponent()' instead of 'escape()' to support multi-byte
    characters on query like Japanese.
* remove fillAddress() due to missing it.
* use 'encodeURIComponent()' instead of 'escape()' to support multi-byte
  characters on query like Japanese.
@nhoag

This comment has been minimized.

nhoag commented Jan 2, 2015

Confirming that @wildtree's patch resolves the following error:

ERROR ReferenceError: fillAddress is not defined
  at TextListener.callback (/path/to/bot/node_modules/hubot-maps/src/maps.coffee:58:16, <js>:57:18)

You can see an instance of fillAddress() here: https://github.com/gkoo/mybot/blob/a031f75843c69f1f2f76153a775938deec1dd7f8/scripts/maps.coffee#L9

Note that this function does not exist in this repo, so was likely not fully scrubbed.

nhoag added a commit to nhoag/hubot-maps that referenced this pull request Jan 2, 2015

@anroots

This comment has been minimized.

anroots commented Jan 15, 2015

This bug exists and renders the script unusable. Please merge.

@mal

This comment has been minimized.

mal commented Mar 1, 2015

@technicalpickles Did you get made a contributor in the end? Any chance you could help out getting this into a release, bit mad to have a broken script as part of the default hubot install! 😛

@technicalpickles

This comment has been minimized.

Collaborator

technicalpickles commented Mar 1, 2015

@mal I did, but forgot to watch the repo 😓 Will check it out.

tadassce added a commit to tadassce/hubot-maps that referenced this pull request Mar 13, 2015

Fix fillAddress()
Just applying:
gkoo#3
@mal

This comment has been minimized.

mal commented Mar 14, 2015

@technicalpickles just a reminder that this still needs to be merged and released please 😈

@Phazz

This comment has been minimized.

Phazz commented Mar 26, 2015

👍 needs merge

technicalpickles added a commit that referenced this pull request Mar 26, 2015

Merge pull request #3 from wildtree/multibyte
fix fillAddress() crash and support mutli-byte characters on query

@technicalpickles technicalpickles merged commit fc39e87 into gkoo:master Mar 26, 2015

@Phazz

This comment has been minimized.

Phazz commented Mar 26, 2015

@technicalpickles Thanks for merging it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment