Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Executing via `lsc -w` renders runtime error unusable #1015

Closed
vendethiel opened this issue Mar 12, 2018 · 6 comments
Closed

Executing via `lsc -w` renders runtime error unusable #1015

vendethiel opened this issue Mar 12, 2018 · 6 comments

Comments

@vendethiel
Copy link
Contributor

@vendethiel vendethiel commented Mar 12, 2018

➜  LiveScript git:(master) ✗ cat ~/err.ls
throw new Error
➜  LiveScript git:(master) ✗ ./bin/lsc -w ~/err.ls
Failed at: ~/err.ls
undefined
@vendethiel vendethiel changed the title watch flag renders runtime error unusable Executing via `lsc` renders runtime error unusable Mar 12, 2018
@vendethiel vendethiel changed the title Executing via `lsc` renders runtime error unusable Executing via `lsc -w` renders runtime error unusable Mar 12, 2018
@vendethiel
Copy link
Contributor Author

@vendethiel vendethiel commented Mar 12, 2018

Without -w:

➜  LiveScript git:(master) ✗./bin/lsc ~/err.ls
Failed at: ~/err.ls
Error
    at Object.<anonymous> (~/err.ls:1:7)
    at Module._compile (module.js:643:30)
    at Module._compile (~/LiveScript/node_modules/source-map-support/source-map-support.js:492:25)
    at Object.LiveScript.run (~/LiveScript/lib/node.js:33:19)
    at compileScript (~/LiveScript/lib/command.js:186:31)
    at ~/LiveScript/lib/command.js:112:11
    at ~/LiveScript/lib/command.js:102:7
    at FSReqWrap.readFileAfterClose [as oncomplete] (fs.js:511:3)
@rhendric
Copy link
Collaborator

@rhendric rhendric commented Mar 12, 2018

It looks like this might have been caused by the fix for #900, but @vendethiel, you said that #900 may not be actually fixed? Should we revert #901 (which I think fixes this) and do something else about #900? Or double down on that change and rewrite it to take o.watch into consideration?

@vendethiel
Copy link
Contributor Author

@vendethiel vendethiel commented Mar 12, 2018

Did we try bumping jison to ..18?

@vendethiel
Copy link
Contributor Author

@vendethiel vendethiel commented Mar 12, 2018

Do note: this one issue is about runtime errors. #900 is something I hit with compile ones.

@rhendric
Copy link
Collaborator

@rhendric rhendric commented Mar 12, 2018

Bumping jison makes sense to me, but I personally haven't tried anything; all I know about these bugs is what's in the bug reports. Maybe @summivox can weigh in? Otherwise, I'd be inclined to do that (remove the .message and bump jison) if it weren't for your report of lingering issues with #900, which makes me worry that I wouldn't notice if there were a regression here.

@summivox
Copy link
Contributor

@summivox summivox commented Mar 15, 2018

I haven't been following the development on either projects, but I'd recommend updating dependency.

@rhendric rhendric added this to To do in Release 1.6.0 Mar 17, 2018
@rhendric rhendric mentioned this issue Mar 26, 2018
@rhendric rhendric moved this from To do to In progress in Release 1.6.0 Mar 26, 2018
Release 1.6.0 automation moved this from In progress to Done Apr 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Release 1.6.0
  
Done
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants