New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twitchless accounts #396

Open
glacials opened this Issue Jun 4, 2018 · 0 comments

Comments

1 participant
@glacials
Owner

glacials commented Jun 4, 2018

Something to think about / investigate.

Features that depend on your Splits I/O account being backed by a Twitch account:

  • Usernames (without a Twitch account, we can't guarantee you don't share a name with someone else, so we'd probably have to separate the two)
  • Therefore API paths
  • Follows
  • Therefore rivals
  • Avatars (need some way to change it -- ActiveStorage? Gravatar?)
  • ???

glacials added a commit that referenced this issue Aug 24, 2018

Move Twitch info into its own table
Moves Twitch info into its own DB table / Rails model. This serves two
purposes:

1. Cleans things up a bit; gets some Twitch user code out of a concern
and into its own model
2. Gets us ready for #396

There should be no user impact from this change.

glacials added a commit that referenced this issue Aug 29, 2018

Move Twitch info into its own table (#440)
* Move Twitch info into its own table

Moves Twitch info into its own DB table / Rails model. This serves two
purposes:

1. Cleans things up a bit; gets some Twitch user code out of a concern
and into its own model
2. Gets us ready for #396

There should be no user impact from this change.

* Remove twitch_display_name from user dashboard

* Include name in migrated TwitchUsers

* Add up/down migrations

* if ! -> unless

* Adjust avatar logic for CR

* Add defaults to SessionsController & migration

* Rubocop & CR

* CR comments

* CR comments #2

@glacials glacials added this to In progress in Splits I/O 2018 Sep 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment