Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQUEST] OptionalEnvString for Monitor.Url field #45

Closed
devsjc opened this issue May 6, 2024 · 1 comment
Closed

[REQUEST] OptionalEnvString for Monitor.Url field #45

devsjc opened this issue May 6, 2024 · 1 comment
Milestone

Comments

@devsjc
Copy link

devsjc commented May 6, 2024

Firstly, thanks for the great application! Very cool to see a Go-backed static site! This is less a feature request and more of a tiny modification request:

For deployments in kubernetes environments, the IP addressess of services are ephemeral, and their current value is passed into containers through environment variables. As such, in a similar manner to how the GITHUB_TOKEN can be parsed from environment through its use of OptionalEnvString, I wondered if the Monitor.Sites.Url field could also be an OptionalEnvString? That way monitors can more easily resolve to Kubernetes services.

Equally, a big part of what helps this stand out to me from the rest of the dashboard apps is it's opinionated and straightforwad nature (much like the backend language it's built with!), so not a problem if you're trying to keep things that way; I appreciate Kube is probably a niche deployment scenario.

@svilenmarkov
Copy link
Member

Hey, not a problem, it's a small change which I can get done for the next release.

@svilenmarkov svilenmarkov added this to the v0.4.0 milestone May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants