Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update User-Agent header to identify as pulsebot #26

Merged
merged 2 commits into from Mar 14, 2019

Conversation

Projects
None yet
2 participants
@globau
Copy link
Contributor

globau commented Mar 13, 2019

Identifying pulsebot via its user-agent permits Bugzilla's user-
based blocking/rate-limiting to whitelist pulsebot.

@@ -14,6 +14,7 @@ class Bugzilla(object):
def __init__(self, server, api_key):
self._server = server.rstrip('/')
self._session = requests.Session()
self._session.headers.update({'User-Agent': 'glandium/pulsebot'})

This comment has been minimized.

@glandium

glandium Mar 13, 2019

Owner

I'd rather not hardcode glandium in there. Could you also add the rationale in the commit message? Is this for filtering on the bugzilla end? Can't filtering be done via api key?

Update User-Agent header to identify as pulsebot
Identifying pulsebot via its user-agent permits Bugzilla's user-agent
based blocking/rate-limiting to whitelist pulsebot.

@glandium glandium merged commit ce18426 into glandium:master Mar 14, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.