Skip to content

gh-1112: distribute redshifts over shells#1114

Open
ntessore wants to merge 11 commits into
mainfrom
nt/1112
Open

gh-1112: distribute redshifts over shells#1114
ntessore wants to merge 11 commits into
mainfrom
nt/1112

Conversation

@ntessore

@ntessore ntessore commented Jun 5, 2026

Copy link
Copy Markdown
Collaborator

Description

Add a new function glass.distribute() that takes an array of redshifts and distributes it over the given shells.

To achieve this, a new multinomial() distribution was added to the RNG interface.

Closes: #1112

Changelog entry

Added: glass.distribute() to distribute an array of redshifts over shells

Checks

  • Is your code passing linting?
  • Is your code passing tests?
  • Have you added additional tests (if required)?
  • Have you modified/extended the documentation (if required)?
  • Have you added a one-liner changelog entry above (if required)?

@ntessore ntessore marked this pull request as ready for review June 5, 2026 20:02

@paddyroddy paddyroddy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some thoughts

Comment thread glass/_rng.py Outdated
Comment thread glass/shells.py Outdated
Comment thread glass/shells.py Outdated
Comment thread glass/shells.py Outdated
Comment thread glass/shells.py Outdated
Comment thread tests/regression/test_shells.py Outdated
Comment thread tests/core/test_shells.py Outdated
Comment thread tests/core/test_shells.py Outdated
Comment thread tests/core/test_shells.py Outdated
Comment thread tests/core/test_shells.py Outdated
Comment thread tests/regression/test_shells.py Outdated
ntessore and others added 4 commits June 8, 2026 19:53
Co-authored-by: Patrick Roddy <patrickjamesroddy@gmail.com>
Co-authored-by: Nicolas Tessore <n.tessore@ucl.ac.uk>
Co-authored-by: Patrick Roddy <patrickjamesroddy@gmail.com>
@ntessore ntessore requested a review from paddyroddy June 9, 2026 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Distribute redshifts over shells

2 participants