Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toml: drop vendored folder #355

Merged
merged 5 commits into from Oct 21, 2023
Merged

toml: drop vendored folder #355

merged 5 commits into from Oct 21, 2023

Conversation

shipperizer
Copy link
Contributor

@shipperizer shipperizer commented Oct 14, 2023

Aim of the PR ois to get rid of the hydronica/toml vendoring and patching

resorted to change the config parsing in a quite surgical way but mixed that with the refactoring
happy to pick only the small change needed to drop the Mapping from MetaData

  • fix: move all toml parsing into a new internal package, drop the mapp…
  • fix: drop vendored toml
  • fix: removed config setup from main, reshoring log configuration
  • fix: upgrade to use BurntSushi/toml

@codesee-maps
Copy link

codesee-maps bot commented Oct 14, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@shipperizer shipperizer marked this pull request as draft October 15, 2023 07:47
@shipperizer
Copy link
Contributor Author

shipperizer commented Oct 15, 2023

@Fusion after a bit of poking around it seems to me that the best way to drop the vendored folder is to branch the toml library and make the fix we need and use that in go.mod

not sure if that s the way u wanna go forward

other solution would be to overhaul the toml setup, pick a newer library and see if we can use that off the shelf, probably useful given that the current one hasn't been updated in 2y and the original fork instead is actively maintained

@shipperizer shipperizer marked this pull request as ready for review October 15, 2023 22:54
@shipperizer
Copy link
Contributor Author

right reworked a bit the parsing and i was able to drop the "Mappings" in favour of toml.Primitive and selective decoding

@sonarcloud
Copy link

sonarcloud bot commented Oct 21, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

No Coverage information No Coverage information
3.5% 3.5% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@Fusion Fusion merged commit 1721e57 into glauth:master Oct 21, 2023
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants