Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/improve plugin integration in build process #381

Merged
merged 3 commits into from Jan 20, 2024

Conversation

Fusion
Copy link
Collaborator

@Fusion Fusion commented Dec 26, 2023

Thank you for making a pull request!

A few things to be aware of as you're working on your PR:

WIP Tag

Incomplete PRs are more than welcome - it can be useful to collaborate before
implementation of an idea is complete. However, if your PR is not ready
for merge, please add [WIP] to the end of the title (work-in-progress).

Tests

Before committing, you are encouraged to run the small but growing test
suite. This is accomplished by make test. Additionally, if you are adding
new functionality, consider adding tests covering your feature.

CI

Each push to a branch connected to a PR will be run through GLAuth's
CI system. Please use these to your advantage. In particular, the Github Actions
integration tests rely on the LDAP queries returning with a set result,
so if your changes will change the output, CI will likely fail.

To update, run make fast && make updatetest && make test. This will
delete the output snapshots provided and make new ones. You can then
inspect the changes and commit them.

Similarly, check codeclimate and try to fix what you find there if it fails.

Copy link

codesee-maps bot commented Dec 26, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Copy link

sonarcloud bot commented Jan 20, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Fusion Fusion merged commit 540631c into master Jan 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant