Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore/remove dependency on goconvey #392

Merged
merged 1 commit into from Feb 11, 2024
Merged

chore/remove dependency on goconvey #392

merged 1 commit into from Feb 11, 2024

Conversation

Fusion
Copy link
Collaborator

@Fusion Fusion commented Jan 20, 2024

Revert back to standard testing, compatible with mocks.

@codesee-maps CodeSee Maps
Copy link

codesee-maps bot commented Jan 20, 2024

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 20, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

26.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

shipperizer
shipperizer approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@shipperizer shipperizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Fusion Fusion merged commit 6d161b7 into master Feb 11, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shipperizer shipperizer shipperizer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Fusion @shipperizer