Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: location for staticlookup and offsetlookup #249

Merged
merged 24 commits into from Feb 17, 2019

Conversation

alexander-akait
Copy link
Collaborator

We already do same for propertylookup. It is allow for prettier format comment like:

$var = $var
    // Comment
    ::each() // Comment
    // Comment
    ::map() // Comment
    // Comment
    ::first() // Comment
    // Comment
    ::dump();

@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 95.124% when pulling 522e051 on fix-location-for-staticlookup-and-offsetlookup into 43b3638 on master.

Copy link
Member

@ichiriac ichiriac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the endOffset = endOffset + 1; statement and what it fixes. I fell that the error may be somewhere else but I need more details on how it behaves without ...?

src/ast.js Outdated Show resolved Hide resolved
@ichiriac ichiriac added the high-pri High Priority bug label Feb 16, 2019
@ichiriac ichiriac merged commit 272951e into master Feb 17, 2019
@ichiriac ichiriac deleted the fix-location-for-staticlookup-and-offsetlookup branch March 2, 2019 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high-pri High Priority bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants