Skip to content

Conversation

@alexander-akait
Copy link
Collaborator

We should saving test to avoid future regression, it is very bad practice if we don't do it

@alexander-akait
Copy link
Collaborator Author

Please don't merge failed PRs (linting) 😞

Maintaining the repository is very terrible, let's stick to standard practices, this solved most of the problems

@ichiriac ichiriac self-requested a review August 28, 2019 13:23
@ichiriac
Copy link
Member

I think it's simpler to add --fix on linter for automatic fixes on precommit hook

Copy link
Member

@ichiriac ichiriac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add option for testing position and extracted source code, that covers the #375

@ichiriac ichiriac merged commit 06e9df3 into master Aug 28, 2019
@alexander-akait alexander-akait deleted the test-assign-by-ref branch August 29, 2019 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants