Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow numbers in project name #991

Merged
merged 2 commits into from
Mar 2, 2021
Merged

Allow numbers in project name #991

merged 2 commits into from
Mar 2, 2021

Conversation

CrowdHailer
Copy link
Contributor

This change also prevents _ being the first character in a project name, which is what the error message already says.

@CrowdHailer CrowdHailer mentioned this pull request Mar 2, 2021
Closed
lpil
lpil approved these changes Mar 2, 2021
View reviewed changes
Copy link
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better, thanks!

@lpil lpil merged commit eec0425 into gleam-lang:main Mar 2, 2021
@CrowdHailer CrowdHailer deleted the numbers-in-project-name branch March 2, 2021 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpil lpil lpil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CrowdHailer @lpil