Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate Glean TOML Dataset #12

Merged
merged 4 commits into from Apr 17, 2014
Merged

Validate Glean TOML Dataset #12

merged 4 commits into from Apr 17, 2014

Commits on Apr 12, 2014

  1. Validate Glean TOML Dataset 

    - Add glean validate command
  - --validator-path flag customizes validator program path
  - The first option sets dataset path and defaults to '.'
- Add Glean::Validator module to encapsulate validator logic
- Validate TOML dataset with tomlv program
  - If tomlv program isn't in the user's $PATH, attempt to install it
- Download platform specific tomlv program from glean/glean-validator repo
  - Glean::Installer asks user where to install tomlv program only
    when --validator-path flag isn't set
  - Glean::Installer gracefully fails in a few cases:
    - User decides not to install tomlv program
    - Platform can't be determined or matched to tomlv program
    - Network error while downloading
- Generate new cassettes for failing specs
    Simeon F. Willbanks committed Apr 12, 2014
    Copy the full SHA
    726fac7 View commit details
    Browse the repository at this point in the history

  2. Prefer hash rockets

    Simeon F. Willbanks committed Apr 12, 2014
    Copy the full SHA
    d0e2ac7 View commit details
    Browse the repository at this point in the history

  3. Replace magic number with intention revealing constant

    Simeon F. Willbanks committed Apr 12, 2014
    Copy the full SHA
    5435723 View commit details
    Browse the repository at this point in the history

  4. Better rspec output

    Simeon F. Willbanks committed Apr 12, 2014
    Copy the full SHA
    4ed288a View commit details
    Browse the repository at this point in the history