Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send email button #14

Merged
merged 1 commit into from Jul 29, 2013
Merged

Send email button #14

merged 1 commit into from Jul 29, 2013

Conversation

@accessd
Copy link
Collaborator

accessd commented Jul 28, 2013

It implements #3

@glebm
Copy link
Owner

glebm commented Jul 29, 2013

I am working on merging this in glebm/send_email_button branch
Could you explain a bit more how the handler works? It does not seem to send anything, and elsewhere online I see that deliver! is the method one would override for a custom handler.

@accessd
Copy link
Collaborator Author

accessd commented Jul 29, 2013

Hi! This is from documentation http://rubydoc.info/github/mikel/mail/Mail/Message:delivery_handler
I checked the sending in development and it worked.

@glebm glebm merged commit f0aaca9 into glebm:master Jul 29, 2013
@glebm
Copy link
Owner

glebm commented Jul 29, 2013

I have merged it as an experimental feature (off by default, set enable_send_email = true to enable)

@glebm
Copy link
Owner

glebm commented Jul 29, 2013

By the way, I've added you as a collaborator (commit access). Thanks for the contribution!

@accessd
Copy link
Collaborator Author

accessd commented Jul 29, 2013

Ok. Cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.