Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upSend email button #14
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
glebm
Jul 29, 2013
Owner
I am working on merging this in glebm/send_email_button branch
Could you explain a bit more how the handler works? It does not seem to send anything, and elsewhere online I see that deliver! is the method one would override for a custom handler.
|
I am working on merging this in |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
accessd
Jul 29, 2013
Collaborator
Hi! This is from documentation http://rubydoc.info/github/mikel/mail/Mail/Message:delivery_handler
I checked the sending in development and it worked.
|
Hi! This is from documentation http://rubydoc.info/github/mikel/mail/Mail/Message:delivery_handler |
glebm
merged commit f0aaca9
into
glebm:master
Jul 29, 2013
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
glebm
Jul 29, 2013
Owner
I have merged it as an experimental feature (off by default, set enable_send_email = true to enable)
|
I have merged it as an experimental feature (off by default, set |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
glebm
Jul 29, 2013
Owner
By the way, I've added you as a collaborator (commit access). Thanks for the contribution!
|
By the way, I've added you as a collaborator (commit access). Thanks for the contribution! |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Ok. Cool! |
accessd commentedJul 28, 2013
It implements #3