New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send email button #14

Merged
merged 1 commit into from Jul 29, 2013

Conversation

Projects
None yet
2 participants
@accessd
Collaborator

accessd commented Jul 28, 2013

It implements #3

@glebm

This comment has been minimized.

Show comment
Hide comment
@glebm

glebm Jul 29, 2013

Owner

I am working on merging this in glebm/send_email_button branch
Could you explain a bit more how the handler works? It does not seem to send anything, and elsewhere online I see that deliver! is the method one would override for a custom handler.

Owner

glebm commented Jul 29, 2013

I am working on merging this in glebm/send_email_button branch
Could you explain a bit more how the handler works? It does not seem to send anything, and elsewhere online I see that deliver! is the method one would override for a custom handler.

@accessd

This comment has been minimized.

Show comment
Hide comment
@accessd

accessd Jul 29, 2013

Collaborator

Hi! This is from documentation http://rubydoc.info/github/mikel/mail/Mail/Message:delivery_handler
I checked the sending in development and it worked.

Collaborator

accessd commented Jul 29, 2013

Hi! This is from documentation http://rubydoc.info/github/mikel/mail/Mail/Message:delivery_handler
I checked the sending in development and it worked.

@glebm glebm merged commit f0aaca9 into glebm:master Jul 29, 2013

@glebm

This comment has been minimized.

Show comment
Hide comment
@glebm

glebm Jul 29, 2013

Owner

I have merged it as an experimental feature (off by default, set enable_send_email = true to enable)

Owner

glebm commented Jul 29, 2013

I have merged it as an experimental feature (off by default, set enable_send_email = true to enable)

@glebm

This comment has been minimized.

Show comment
Hide comment
@glebm

glebm Jul 29, 2013

Owner

By the way, I've added you as a collaborator (commit access). Thanks for the contribution!

Owner

glebm commented Jul 29, 2013

By the way, I've added you as a collaborator (commit access). Thanks for the contribution!

@accessd

This comment has been minimized.

Show comment
Hide comment
@accessd

accessd Jul 29, 2013

Collaborator

Ok. Cool!

Collaborator

accessd commented Jul 29, 2013

Ok. Cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment