Skip to content
Permalink
Branch: master
Commits on Dec 11, 2011
  1. Remove definition of Array#all?

    ronen committed Dec 11, 2011
    I don't know why core_ext defines Array#all? since Enumerable#all? does the same thing (in MRI 1.8.7 and 1.9.3)
    
    Except that this extension doesn't support the behaviour that "If the block is not given, Ruby adds an implicit block of {|obj| obj} (that is all? will return true only if none of the collection members are false or nil.)" http://www.ruby-doc.org/core-1.9.3/Enumerable.html#method-i-all-3F 
    
    So with this definition, including ruby-graphviz breaks any existing code that calls an_array.all? without a block.
    
    And without this local extension, the tests seem to pass anyway (again, in MRI 1.8.7 and 1.9.3).
Commits on Nov 20, 2011
  1. Change Config to RbConfig

    ronen committed Nov 20, 2011
    as per deprecation warning in ruby 1.9.3:
      .../ruby-1.9.3-p0/gems/ruby-graphviz-1.0.0/lib/graphviz/utils.rb:26: Use RbConfig instead of obsolete and deprecated Config.
You can’t perform that action at this time.