Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Find executable #47

Merged
merged 2 commits into from Jul 1, 2012

Conversation

Projects
None yet
2 participants
Contributor

markus1189 commented Jul 1, 2012

Hi,

First of all I want to thank you for your work. I recently used Ruby-Graphviz to visualize some data and I really appreciate your efforts.

However after cloning I had some problems running your tests:

84 tests, 229 assertions, 11 failures, 1 errors, 0 skips

I found the problem in graphviz/utils.rb:find_executable.

I changed the method to prepend the given paths to the content of PATH, because by that the additionally given paths is prioritzed when searching but if not successfull it still searches the other possible places on your system leading to (hopefully) the right dot executable.

Maybe you want to have a look :)

markus1189 added some commits Jul 1, 2012

@markus1189 markus1189 Changed find_executable to prepend custom paths
Instead of using the additionally given path exclusively, the method now
prepends any given path to prioritize it.
00fd2c0
@markus1189 markus1189 Added guard clause to @path assignment 8f452dc

This gave me split on nil error, I did not look very closely what would be a better solution but with this all tests pass on my machine (ubuntu)

@glejeune glejeune added a commit that referenced this pull request Jul 1, 2012

@glejeune glejeune Merge pull request #47 from markus1189/find_executable
Find executable
ea78c63

@glejeune glejeune merged commit ea78c63 into glejeune:master Jul 1, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment