Bugs fixed. Convinient function added. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nging not copy of prev in RemoveElement function. Besides new Insert, returning *Element added
pashaosipyants
commented
Feb 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was two bugs:
-one appeares when one tries to Get or Remove from empty list. (prevs function returns empty slice in this case, and there wasn't a check for this before prev[0] indexing)
-the other appeares when one tries RemoveElement with a key, which have several elements in the list. (infinite loop because of changing copy of variable)
Besides there was a lack of Insert function that returns the newly created Element (issue #2 )