Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling reverse DNS lookup lists wrong host when using a bnc #21

Closed
steakboy7000 opened this issue Nov 26, 2019 · 3 comments
Closed

Disabling reverse DNS lookup lists wrong host when using a bnc #21

steakboy7000 opened this issue Nov 26, 2019 · 3 comments

Comments

@steakboy7000
Copy link

@steakboy7000 steakboy7000 commented Nov 26, 2019

Normally, lines in login.log look something like:

Tue Nov 26 21:15:48 2019 [13702   ] LOGIN: *@<reverse-dns> (<real-ip>) <bnc-ip> <username> <group> <tagline>

When disabling reverse DNS lookup (-n 0 as command line argument) it instead looks like:

Tue Nov 26 21:15:48 2019 [13702   ] LOGIN: *@<bnc-ip> (<real-ip>) <bnc-ip> <username> <group> <tagline>

I would expect the real ip to show up as host, not the bnc ip.

@Skeddie

This comment has been minimized.

Copy link
Collaborator

@Skeddie Skeddie commented Dec 1, 2019

I can't seem to replicate this, could you inform us which bnc is being used? Tested with simpleentry and cubnc.

@steakboy7000

This comment has been minimized.

Copy link
Author

@steakboy7000 steakboy7000 commented Dec 4, 2019

I was using cbbncd: https://cbftp.eu/cbbncd-0.11.tar.gz

It turns out that this happens because cbbncd is using IDNT incorrectly, or at least differently, which triggers this behavior in gl.

other bnc's send IDNT <ident>@<ip>:<ip> where the latter ip is a field intended for reverse dns.
cbbncd sends IDNT <ident>@<ip> and as such does not provide a revdns.
Normally glftpd handles the reverse DNS lookup so the revdns field from the bnc won't matter, but when reverse DNS lookup is disabled in gl it will instead use the revdns as provided from the bnc, and since no revdns was provided it simply uses the bnc ip. I guess this can be considered not a bug then, even though it would make more sense to use the bnc-provided ip rather than the ip of the bnc in this case.

@Skeddie

This comment has been minimized.

Copy link
Collaborator

@Skeddie Skeddie commented Dec 5, 2019

even though it would make more sense to use the bnc-provided ip rather than the ip of the bnc in this case.

I concur. While the matter is fixed in the latest cbbncd v0.12, a fix is also provided in upcoming 2.10 BETA2.

@Skeddie Skeddie closed this Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.