Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning about "_GNU_SOURCE" redefined #2133

Closed
alexballas opened this issue Jun 16, 2022 · 3 comments
Closed

Warning about "_GNU_SOURCE" redefined #2133

alexballas opened this issue Jun 16, 2022 · 3 comments
Assignees
Labels
bug Bug reports and bugfix pull requests build Build file bugs and PRs (not compilation errors) duplicate Issues duplicating another issue external Issues GLFW cannot reasonably solve verified Reproduced or otherwise verified bugs X11
Milestone

Comments

@alexballas
Copy link

Compiling for Linux x86_64 (Ubuntu 18.04) throws a Warning

# github.com/go-gl/glfw/v3.3/glfw
In file included from ../../go/pkg/mod/github.com/go-gl/glfw/v3.3/glfw@v0.0.0-20220516021902-eb3e265c7661/c_glfw_lin.go:20:0:
../../go/pkg/mod/github.com/go-gl/glfw/v3.3/glfw@v0.0.0-20220516021902-eb3e265c7661/glfw/src/x11_window.c:30:0: warning: "_GNU_SOURCE" redefined
 #define _GNU_SOURCE
 
<command-line>:0:0: note: this is the location of the previous definition

I understand that this is just a Warning, but it would be good if it could be silenced or fixed.
Let me know if you'd like more info on this

@elmindreda
Copy link
Member

This seems like a duplicate of #2076. GLFW started defining a macro that the Go bindings were already defining in their custom build system. This should be fixed on their end now.

@elmindreda elmindreda added X11 external Issues GLFW cannot reasonably solve build Build file bugs and PRs (not compilation errors) labels Jun 21, 2022
@elmindreda elmindreda self-assigned this Jun 21, 2022
@elmindreda elmindreda added the waiting for reply Issues blocked waiting for information label Jun 21, 2022
@dmitshur
Copy link
Collaborator

I agree this looks like a duplicate of #2076, and should be discussed in go-gl/glfw#351.

We've just pushed a fix that should resolve that issue, @alexballas please feel free to try again with the latest version (e.g., go get github.com/go-gl/glfw/v3.3/glfw@v0.0.0-20220622232848-a6c407ee30a0), and comment in go-gl/glfw#351 if the issue with the Go package persists.

@alexballas
Copy link
Author

thanks for that. The new go-gl version did fix the issue.

@elmindreda elmindreda added bug Bug reports and bugfix pull requests duplicate Issues duplicating another issue verified Reproduced or otherwise verified bugs and removed waiting for reply Issues blocked waiting for information labels Jun 23, 2022
@elmindreda elmindreda added this to the None milestone Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports and bugfix pull requests build Build file bugs and PRs (not compilation errors) duplicate Issues duplicating another issue external Issues GLFW cannot reasonably solve verified Reproduced or otherwise verified bugs X11
Projects
None yet
Development

No branches or pull requests

3 participants