Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap interval ignored when DWM is enabled #516

Closed
expipiplus1 opened this issue May 19, 2015 · 4 comments

Comments

Projects
None yet
2 participants
@expipiplus1
Copy link

commented May 19, 2015

This certainly isn't a major issue, it might not even be worth correcting just for a test.

The joysticks test fully "utilizes" the cpu on machines I've tested it on. Is it worth enabling vsync or sleeping every frame to prevent this?
I sometimes use this test as a quick way of debugging joystick inputs, it would be nice if it wasn't quite as wasteful :)

@elmindreda

This comment has been minimized.

Copy link
Member

commented May 21, 2015

That test already has vsync enabled.

@elmindreda elmindreda closed this May 21, 2015

@elmindreda elmindreda self-assigned this May 21, 2015

@elmindreda elmindreda added this to the milestone May 21, 2015

@elmindreda elmindreda added the question label May 21, 2015

@expipiplus1

This comment has been minimized.

Copy link
Author

commented May 21, 2015

So it seems as though this was caused by an issue with vsync on Windows 10. Solved in the dwmflush branch at the moment. Thanks!

elmindreda added a commit that referenced this issue May 21, 2015

Use DwmFlush when DWM is enabled.
Use DwmFlush instead of WGL_EXT_swap_control when desktop compositing is
enabled, to avoid the jitter of DWM and WGL vsync fighting.

Fixes #516.

@elmindreda elmindreda added bug Windows verified and removed question labels May 21, 2015

@elmindreda elmindreda modified the milestones: 3.2, May 21, 2015

@elmindreda elmindreda changed the title Joystick test has high cpu usage Swap interval ignored when DWM is enabled May 21, 2015

@elmindreda

This comment has been minimized.

Copy link
Member

commented May 21, 2015

I'm stealing this for the bugfix. I hope that's all right.

@expipiplus1

This comment has been minimized.

Copy link
Author

commented May 21, 2015

no problem.

@elmindreda elmindreda modified the milestones: 3.2, 3.1.2 Jun 7, 2015

@mirh mirh referenced this issue Jul 21, 2017

Closed

Triple Buffering #563

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.