Add keyboard layout callback and name query #1696
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a keyboard layout switch callback and a query for the human-readable name of the current layout. Fixes #1201.
elmindreda
added
enhancement
|
Does the IME inconsistency on other platforms mean that it won't get notified at all on a change like hiragana/katakana or that the names will just appear to be the same? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a global callback for when the keyboard layout changes and a query for the localized, human-readable name of the current layout.
On macOS it also triggers when the mode changes for an IME, for example switching between hiragana and katakana, while on other platforms they are both referred to as
Japaneseor similar. I don't know whether or how to fix that inconsistency.On Wayland the name query returns data cached from received events but on other platforms it queries the system directly.
This PR is intended to fix #1201.
This functionality may be affected by IME support work before 3.4 release.