Implement glfwGetCursorPos #499

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@linkmauve
Member

Pointer motion events were already handled, it was just lacking the actual exposition to the API.

@linkmauve linkmauve changed the title from wayland: implement glfwGetCursorPos to wayland: Implement glfwGetCursorPos Apr 15, 2015
@elmindreda elmindreda added the Wayland label Apr 15, 2015
@elmindreda elmindreda changed the title from wayland: Implement glfwGetCursorPos to Implement glfwGetCursorPos Apr 15, 2015
@linkmauve
Member

Oops, my rebase erased jadahl’s comment (and fixed the main issue).

Anyway, to answer that question, I think pointer events from outside of the window are very useful in some cases, think an OpenLayers-like map application, the user wants to be able to scroll even outside of the window, it makes a frustrating experience if the window is small and input stops at the edges of the window.

@elmindreda
Member

The comment is still there: linkmauve/glfw@be327a3

@jadahl
Contributor
jadahl commented Apr 17, 2015

The wl_*.c part looks fine now. @elmindreda, can you confirm the change to input.c is correct and won't break other platforms?

@elmindreda
Member

@jadahl It's... tolerable. I'd rather it use platform local variables instead of re-introducing shared logic that will do nothing on any other platform.

If Mir works the same as Wayland then I guess this way is all right.

@linkmauve
Member

Addressed your issues, everything stays in the wl_* files now.

@elmindreda elmindreda added a commit that closed this pull request Apr 19, 2015
@linkmauve @elmindreda linkmauve + elmindreda wayland: Implement glfwGetCursorPos
Closes #499.
e253bea
@elmindreda
Member

Merged. Thank you!

@elmindreda elmindreda self-assigned this Apr 19, 2015
@elmindreda elmindreda added this to the 3.2 milestone Apr 19, 2015
@elmindreda elmindreda modified the milestone: 3.2, 3.1.2 Jun 7, 2015
@linkmauve linkmauve deleted the linkmauve:wayland-mouse branch Jun 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment