New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'first responder' error on 10.12 #883

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@tikhomirov
Copy link
Contributor

tikhomirov commented Oct 15, 2016

Error message is displayed during the startup because Cocoa view is set as the first responder for window but this view isn't in this window (actually it is not in any window at all).

Fixes the issue described in #876. Tested only on macOS 10.12.

@elmindreda elmindreda changed the title Fix 'first responder' error on macOS 10.12 Fix 'first responder' error on 10.12 Oct 15, 2016

@elmindreda elmindreda self-assigned this Oct 15, 2016

@elmindreda

This comment has been minimized.

Copy link
Member

elmindreda commented Oct 16, 2016

Instead of nested views, why not move the call to NSWindow setContentView to the top of the block?

@elmindreda

This comment has been minimized.

Copy link
Member

elmindreda commented Oct 16, 2016

In either case, thank you for spotting the cause of the error!

@elmindreda elmindreda added the verified label Oct 16, 2016

@elmindreda elmindreda added this to the 3.3 milestone Oct 16, 2016

Cocoa: Fix 'first responder' error on macOS 10.12
Error message is displayed during the startup because Cocoa view is set
as the first responder for window but this view isn't in this window
(actually it is not in any window at all).

@tikhomirov tikhomirov force-pushed the tikhomirov:fix-first-responder-error-on-sierra branch from 06d04c9 to ec7701b Oct 16, 2016

@tikhomirov

This comment has been minimized.

Copy link
Contributor Author

tikhomirov commented Oct 16, 2016

why not move the call to NSWindow setContentView

right, somehow I missed this option 😄 I've updated PR

elmindreda added a commit that referenced this pull request Oct 16, 2016

Cleanup
Related to #883.
@elmindreda

This comment has been minimized.

Copy link
Member

elmindreda commented Oct 16, 2016

This has been merged as 967e837, with additional cleanup in 99c65bb. Thank you!

@tikhomirov tikhomirov deleted the tikhomirov:fix-first-responder-error-on-sierra branch Oct 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment