Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add toArray function to convert NodeList to Array #603

Merged
merged 1 commit into from
Feb 9, 2022
Merged

feat: add toArray function to convert NodeList to Array #603

merged 1 commit into from
Feb 9, 2022

Conversation

samuelfullerthomas
Copy link
Contributor

  • for ie11 compatibility

@samuelfullerthomas
Copy link
Contributor Author

samuelfullerthomas commented Feb 8, 2022 •
edited
Loading

Ran into an issue with ie11 throwing for the resetArrowState function, and so wrote this to make the forEach compatible with ie11, which doesn't support forEach for NodeList.

https://developer.mozilla.org/en-US/docs/Web/API/NodeList/forEach#browser_compatibility

Screenshot 2022-02-08 at 10 58 06

@jedrzejchalubek jedrzejchalubek merged commit 9bf8f46 into glidejs:master Feb 9, 2022
@jedrzejchalubek
Copy link
Member

Looks nice! Merging, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samuelfullerthomas @jedrzejchalubek