Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wget to support HTTPS #218

Closed
gliptak opened this issue Oct 18, 2016 · 4 comments
Closed

wget to support HTTPS #218

gliptak opened this issue Oct 18, 2016 · 4 comments
Labels

Comments

@gliptak
Copy link

gliptak commented Oct 18, 2016

A number of bootstrap scripts (like https://bootstrap.pypa.io/get-pip.py or https://get.haskellstack.org/) are being served using HTTPS, which wget doesn't seem to support in the Alpine base image.
Based on https://bugs.alpinelinux.org/issues/5376 I ran

apk upgrade libssl1.0 --update-cache
apk add wget ca-certificates

which enabled HTTPS support.
Could this be made part of the base image?
Thanks

@ncopa
Copy link
Collaborator

ncopa commented Oct 18, 2016

The problem with adding those to the base image is that not everyone needs them and things that are added to base image cannot be removed. (you can remove but it will not reduce space)

Instead you can do:

...
RUN apk add --no-cache --virtual .bootstrap-deps wget ca-certificates \
    && <do the bootstrap script thingy here> \
    && apk del .bootstrap-deps

That way you will temporarily install the deps needed to do your thing and then remove those when no longer needed.

@gliptak
Copy link
Author

gliptak commented Oct 18, 2016

Thank you @ncopa for pointing out the build step (I will make use of :) ). Image size being a concern, maybe wget could also be removed from the base image and could be added (temporarily) by the users who require it (and they could configure with or without HTTPS support)?

@andyshinn
Copy link
Contributor

The wget in the base image is actually provided by BusyBox. Check out the built-in utilities at https://busybox.net/downloads/BusyBox.html.

@gliptak
Copy link
Author

gliptak commented Oct 25, 2016

@andyshinn Thank you for the pointer. I submitted https://bugs.busybox.net/show_bug.cgi?id=9376

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants