Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backends should set a ttl? #5

Closed
virtuald opened this issue Jul 27, 2014 · 2 comments
Closed

backends should set a ttl? #5

virtuald opened this issue Jul 27, 2014 · 2 comments

Comments

@virtuald
Copy link
Contributor

I keep ending up with various invalid keys when rebooting a system, presumably because of an ordering problem on shutdown. However, you could imagine that if a host had a hard shutdown, then the keys associated with containers on the host would never go invalid either.

Currently (at least with etcd backend), registrator does not set a TTL, so the key lives forever and is never removed. A TTL (or some expiration mechanism) should be set on the keys so they expire.

@progrium
Copy link
Contributor

Hmm, yeah I'm thinking of a heartbeat option that will cause values to be
set with a TTL and then registrator handles triggering a heartbeat method
of the registry interface.

On Sat, Jul 26, 2014 at 10:58 PM, Dustin Spicuzza notifications@github.com
wrote:

I keep ending up with various invalid keys when rebooting a system,
presumably because of an ordering problem on shutdown. However, you could
imagine that if a host had a hard shutdown, then the keys associated with
containers on the host would never go invalid either.

Currently (at least with etcd backend), registrator does not set a TTL, so
the key lives forever and is never removed. A TTL (or some expiration
mechanism) should be set on the keys so they expire.


Reply to this email directly or view it on GitHub
https://github.com/progrium/registrator/issues/5.

Jeff Lindsay
http://progrium.com

@progrium
Copy link
Contributor

progrium commented Sep 1, 2014

This is lower priority though since the main use case is with Consul services, which includes health checks that would resolve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants