Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test env build #109

Merged
merged 3 commits into from Jul 3, 2017

Conversation

@pittst3r
Copy link
Contributor

commented Jun 5, 2017

If EMBER_ENV is test then Rollup is run with tests.js as its entry file, where tests.js is a generated file importing all colocated -test files. Colocated means this:

src
└── ui
    └── components
        └── hello-glimmer
            ├── component-test.ts
            ├── component.ts
            └── template.hbs

Concerns like which test framework is used are left to the app/blueprint.

To-do:

@pittst3r pittst3r force-pushed the pittst3r:testing branch 7 times, most recently from 8ebd278 to eb560e9 Jun 9, 2017

@pittst3r pittst3r changed the title WIP: Test env build Test env build Jun 14, 2017

@pittst3r

This comment has been minimized.

Copy link
Contributor Author

commented Jun 14, 2017

@rwjblue This seems pretty good to me now. Ready for a review at your convenience.

const path = require('path');
const walkSync = require('walk-sync');

export default function TestEntrypointBuilder(testTree, options = {}) {

This comment has been minimized.

Copy link
@rwjblue

rwjblue Jun 14, 2017

Member

Can we use class syntax here?

This comment has been minimized.

Copy link
@pittst3r

pittst3r Jun 14, 2017

Author Contributor

I tried, TSC wasn't happy. Figured it out now though. Update incoming.

@rwjblue

This comment has been minimized.

Copy link
Member

commented Jun 14, 2017

Do you have a spike of the blueprint that I can take a look at? Just to see some example usage?

Also, we should add blueprints/glimmer-component-test and blueprints/glimmer-helper-test to this repo so that when someone runs ember g glimmer-component they get a test...

@pittst3r pittst3r force-pushed the pittst3r:testing branch from eb560e9 to e8aa7e8 Jun 14, 2017

@pittst3r

This comment has been minimized.

Copy link
Contributor Author

commented Jun 14, 2017

@pittst3r pittst3r referenced this pull request Jun 16, 2017
3 of 3 tasks complete

@pittst3r pittst3r changed the title Test env build WIP: Test env build Jun 19, 2017

@pittst3r pittst3r force-pushed the pittst3r:testing branch 3 times, most recently from f313680 to 1c949a1 Jun 23, 2017

@pittst3r pittst3r changed the title WIP: Test env build Test env build Jun 23, 2017

@pittst3r pittst3r referenced this pull request Jun 27, 2017
10 of 10 tasks complete

@pittst3r pittst3r changed the title Test env build WIP: Test env build Jun 27, 2017

@pittst3r pittst3r force-pushed the pittst3r:testing branch from 1c949a1 to 9610472 Jul 3, 2017

@pittst3r pittst3r changed the title WIP: Test env build Test env build Jul 3, 2017

@rwjblue rwjblue merged commit 464323b into glimmerjs:master Jul 3, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pittst3r pittst3r deleted the pittst3r:testing branch Jul 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.