Plumb debug symbols when using lexical scope#1634
Conversation
This change introduces a new `emit.debugSymbols` option that can be used to enable debug symbols when using lexical scope.
3b9e91b to
90a1331
Compare
|
duration phase no difference [-308ms to 72ms] [16:50:23] Generating Benchmark Reports [started] JSON: /home/runner/work/glimmer-vm/glimmer-vm/tracerbench-results/compare.json PDF: /home/runner/work/glimmer-vm/glimmer-vm/tracerbench-results/artifact-1.pdf HTML: /home/runner/work/glimmer-vm/glimmer-vm/tracerbench-results/artifact-1.html |
NullVoxPopuli
left a comment
There was a problem hiding this comment.
Approving because in 3 benches, it seems this change has no impact
.. and i probably need to run benches locally because we're not able to trust the stability of the results.
This case is not fixed by the current PR:
```
<p {{some.modifier}}>
```
It probably *should* result in `some.modifier` appearing as the `name`
in the debug modifier tree, but the codepaths improved in the current PR
don't fix that case. For this PR, we'll use the debug name provided by
the modifier manager, which is at least not a regression.
A future PR should systematically fix all of the cases that end up in
the debug tree so that they *always* show "what the user typed",
regardless of how it got converted into running code.


This change introduces a new
emit.debugSymbolsoption that can be used to enable debug symbols when using lexical scope.