New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds regression test for issue #132 which appears fixed on master #133

Merged
merged 1 commit into from Jun 21, 2018

Conversation

Projects
None yet
3 participants
@happycollision
Copy link
Contributor

happycollision commented Jun 21, 2018

As per @lifeart's request, I am adding this test for a broken syntax in v0.9.1 (It is now fixed in master). Referenced in issue #132.

I do not know if this is the best place for this test, so suggestions are welcome.

(I did check the test at the v0.9.1 tag, and it fails there.)

Adds *passing* test for issue #132
This tests behavior that is broken in the v0.9.1 release, but is already fixed in master. I am proposing that this test be added as a regression test, since the behavior worked—and subsequently broke—sometime prior to v0.9.1.

@rwjblue rwjblue merged commit 2ca5e2a into glimmerjs:master Jun 21, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rwjblue

This comment has been minimized.

Copy link
Member

rwjblue commented Jun 21, 2018

Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment