From a116fc208ad38184bfeab216a59666a7f4476b8f Mon Sep 17 00:00:00 2001 From: Jonathan Jackson Date: Mon, 22 Oct 2018 11:56:06 -0400 Subject: [PATCH 1/4] Bump glimmer-application-pipeline dependency --- packages/@glimmer/blueprint/files/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/@glimmer/blueprint/files/package.json b/packages/@glimmer/blueprint/files/package.json index 39bf53f5f..c620b6813 100644 --- a/packages/@glimmer/blueprint/files/package.json +++ b/packages/@glimmer/blueprint/files/package.json @@ -14,7 +14,7 @@ }, "devDependencies": { "@glimmer/application": "^0.12.0", - "@glimmer/application-pipeline": "^0.10.0", + "@glimmer/application-pipeline": "^0.11.2", "@glimmer/blueprint": "~<%= blueprintVersion %>", "@glimmer/component": "^0.12.0", "@glimmer/inline-precompile": "^1.0.0", From bfd36d242137b2ae54e9027b0f907c6c7e3c4d36 Mon Sep 17 00:00:00 2001 From: Jonathan Jackson Date: Sat, 3 Nov 2018 11:12:56 -0400 Subject: [PATCH 2/4] Implement testing concerns The following is meant to satisfy the PR in glimmer application pipeline found here: https://github.com/glimmerjs/glimmer-application-pipeline/pull/152 That PR takes the output from the `/tests/index.html` and bundles it with the appropriate testEntryPoint in the dist after a build. (Sidenote: it does this in all non production environments rather than just test) In order for the process for new Glimmer apps to be smooth we need to utilize that PR (from glimmer application pipeline) and then also do the following (implemented in this PR): - Bump package version of glimmer-application-pipeilne (the assumption of this PR is that when we release glimmer-application-pipeline it will be bumped as a patch version to 0.11.3 - Add the default `tests/index.html` to the root of the project. This is what will be used by glimmer-application-pipeline - *note here* it uses a CDN url for QUnit because that is easier in a future PR we'll have glimmer-application-pipeline handle this such that it is available in the dist - Finally we must update the testem.json to point to `tests/index.html` which (as a result of how ember-cli works) is relative to the `dist` folder already. --- The benefits of this is that we can get a modern version of QUnit. Until this point new glimmer applications could only have 1 function that consumes the `hooks` per module which is stifling for a number of reasons. Furthermore, this PR (and its associated glimmer-application-pipeline PR) bring glimmer applications closer to the harness of Ember itself. --- .../@glimmer/blueprint/files/package.json | 2 +- packages/@glimmer/blueprint/files/testem.json | 4 +--- .../@glimmer/blueprint/files/tests/index.html | 22 +++++++++++++++++++ 3 files changed, 24 insertions(+), 4 deletions(-) create mode 100644 packages/@glimmer/blueprint/files/tests/index.html diff --git a/packages/@glimmer/blueprint/files/package.json b/packages/@glimmer/blueprint/files/package.json index c620b6813..55566bb26 100644 --- a/packages/@glimmer/blueprint/files/package.json +++ b/packages/@glimmer/blueprint/files/package.json @@ -14,7 +14,7 @@ }, "devDependencies": { "@glimmer/application": "^0.12.0", - "@glimmer/application-pipeline": "^0.11.2", + "@glimmer/application-pipeline": "^0.11.3", "@glimmer/blueprint": "~<%= blueprintVersion %>", "@glimmer/component": "^0.12.0", "@glimmer/inline-precompile": "^1.0.0", diff --git a/packages/@glimmer/blueprint/files/testem.json b/packages/@glimmer/blueprint/files/testem.json index f857daa3d..0231f1634 100644 --- a/packages/@glimmer/blueprint/files/testem.json +++ b/packages/@glimmer/blueprint/files/testem.json @@ -1,7 +1,5 @@ { - "framework": "qunit", - "src_files": ["src/**/*"], - "serve_files": ["index.js"], + "test_page": "tests/index.html", "disable_watching": true, "launch_in_ci": ["Firefox", "Chrome"] } diff --git a/packages/@glimmer/blueprint/files/tests/index.html b/packages/@glimmer/blueprint/files/tests/index.html new file mode 100644 index 000000000..df4131372 --- /dev/null +++ b/packages/@glimmer/blueprint/files/tests/index.html @@ -0,0 +1,22 @@ + + + + + + Glimmer PDP Viewer Tests + + + + + + + + + + +
+
+
+
+ + From 48374bed1f2d88096d3c8421916fe0274300af8e Mon Sep 17 00:00:00 2001 From: Jonathan Jackson Date: Mon, 5 Nov 2018 09:38:28 -0500 Subject: [PATCH 3/4] Bump to final release version 0.13.0 --- packages/@glimmer/blueprint/files/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/@glimmer/blueprint/files/package.json b/packages/@glimmer/blueprint/files/package.json index 55566bb26..c84e3ce9d 100644 --- a/packages/@glimmer/blueprint/files/package.json +++ b/packages/@glimmer/blueprint/files/package.json @@ -14,7 +14,7 @@ }, "devDependencies": { "@glimmer/application": "^0.12.0", - "@glimmer/application-pipeline": "^0.11.3", + "@glimmer/application-pipeline": "^0.13.0", "@glimmer/blueprint": "~<%= blueprintVersion %>", "@glimmer/component": "^0.12.0", "@glimmer/inline-precompile": "^1.0.0", From 04dfabce36b3784741dace5ebb046c4f03c334a5 Mon Sep 17 00:00:00 2001 From: Jonathan Jackson Date: Mon, 5 Nov 2018 09:45:19 -0500 Subject: [PATCH 4/4] Address review concerns --- packages/@glimmer/blueprint/files/tests/index.html | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/@glimmer/blueprint/files/tests/index.html b/packages/@glimmer/blueprint/files/tests/index.html index df4131372..1f1e59ddb 100644 --- a/packages/@glimmer/blueprint/files/tests/index.html +++ b/packages/@glimmer/blueprint/files/tests/index.html @@ -3,12 +3,12 @@ - Glimmer PDP Viewer Tests + <%= name %> - - + +