New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple frontend support #110

Merged
merged 4 commits into from Jul 30, 2017

Conversation

Projects
None yet
3 participants
@marrus-sh

marrus-sh commented Jul 29, 2017

How 2 Install New Frontend:

  1. Put frontend files in app/javascript/ directory, eg app/javascript/my-frontend/…
  2. Create app/javascript/packs/frontends/my-frontend.js to load the files. my-frontend will be used as the name of the frontend.

Right now the frontend is selected by Query Parameter; see this line for changing that.

See #20 which did the same thing.

marrus-sh added some commits Jul 29, 2017

@beatrix-bitrot beatrix-bitrot requested a review from MightyPork Jul 29, 2017

@MightyPork

MightyPork approved these changes Jul 29, 2017 edited

LGTM, got a simple front-end working with this, even with a custom stylesheet. It'd be nice to have a proper front-end picker somewhere in the settings, but that can be added later

screenshot_20170729_235533

require('mastodon-application-style');
require.context('../images/', true);

This comment has been minimized.

@MightyPork

MightyPork Jul 29, 2017

This looks like it's not needed here, as the file is never used with multi-frontends? Maybe better we remove this to avoid possible conflicts

This comment has been minimized.

@marrus-sh

marrus-sh Aug 1, 2017

(Sorry ignore previous comment I misunderstood)

ummmm maybe :P

@beatrix-bitrot

This comment has been minimized.

beatrix-bitrot commented Jul 30, 2017

o

there's a conflict!

@marrus-sh ....

@MightyPork MightyPork merged commit b61e3da into master Jul 30, 2017

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@MightyPork MightyPork deleted the more-frontends-yet-again branch Aug 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment