Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port single-column feature from upstream #1108

Merged
merged 28 commits into from Jun 13, 2019

Conversation

Projects
None yet
6 participants
@ThibG
Copy link

commented Jun 12, 2019

Fixes #1066

image

image

  • Interaction with wide columns: wide columns does not apply to single-column mode
  • Interaction between client-side layout choice: automatic uses upstream's setting, other values override it

TODO: extensively test it

@ThibG ThibG force-pushed the ThibG:glitch-soc/features/single-column branch 6 times, most recently from 808ca99 to afec3fd Jun 12, 2019

Gargron and others added some commits May 22, 2019

[Glitch] Add single-column mode
Port 9ddeb30 to glitch-soc

Signed-off-by: Thibaut Girka <thib@sitedethib.com>
[Glitch] Various improvements to single column layout
Port 84dc21d to glitch-soc

Signed-off-by: Thibaut Girka <thib@sitedethib.com>
[Glitch] Add responsive panels to the single-column layout
Port 1e5532e to glitch-soc

Signed-off-by: Thibaut Girka <thib@sitedethib.com>
[Glitch] Improvements to the single column layout
Port 0e445eb to glitch-soc

Signed-off-by: Thibaut Girka <thib@sitedethib.com>
[Glitch] Fix wrong redirect from getting started to home in advanced …
…Web UI

Port 4a818ac to glitch-soc

Signed-off-by: Thibaut Girka <thib@sitedethib.com>
[Glitch] Display notifications count on a new single column
Port 3593b85 to glitch-soc

Signed-off-by: Thibaut Girka <thib@sitedethib.com>
[Glitch] Refactor footers in web UI into a single component
Port 451e598 to glitch-soc

Signed-off-by: Thibaut Girka <thib@sitedethib.com>
[Glitch] Center 2-columns layout without side effect
Port 7c1ca0c to glitch-soc

Signed-off-by: Thibaut Girka <thib@sitedethib.com>
[Glitch] Improvement variable height in single column layout
Port d93b82a to glitch-soc

Signed-off-by: Thibaut Girka <thib@sitedethib.com>
[Glitch] Add profile directory link to single column navigation panel
Port 6077eca to glitch-soc

Signed-off-by: Thibaut Girka <thib@sitedethib.com>
[Glitch] Fix margins on profile metadata in single column mode
Port ed19f33 to glitch-soc

Signed-off-by: Thibaut Girka <thib@sitedethib.com>
[Glitch] Fix emoji picker being always displayed
Port c402c29 to glitch-soc

Signed-off-by: Thibaut Girka <thib@sitedethib.com>
[Glitch] Fix overlap of emoji button on search popup
Port fe3bf3b to glitch-soc

Signed-off-by: Thibaut Girka <thib@sitedethib.com>
[Glitch] Fix some React warnings
Port cc8f6b3 to glitch-soc

Signed-off-by: Thibaut Girka <thib@sitedethib.com>
[Glitch] Fix position of search icon
Port 9add88a to glitch-soc

Signed-off-by: Thibaut Girka <thib@sitedethib.com>

@ThibG ThibG force-pushed the ThibG:glitch-soc/features/single-column branch from 1ce37d3 to 0f17198 Jun 12, 2019

@ThibG ThibG marked this pull request as ready for review Jun 12, 2019

@ThibG ThibG force-pushed the ThibG:glitch-soc/features/single-column branch from 8e118dc to cca5508 Jun 12, 2019

@ThibG ThibG force-pushed the ThibG:glitch-soc/features/single-column branch from cca5508 to 67d2d1d Jun 12, 2019

@ThibG ThibG force-pushed the ThibG:glitch-soc/features/single-column branch from e9b9485 to c8f180c Jun 12, 2019

ThibG added some commits Jun 12, 2019

[Glitch] Fix border-bottom of active tab bars
Port faafc3a to glitch-soc

Signed-off-by: Thibaut Girka <thib@sitedethib.com>
[Glitch] Only show profile directory link when it's enabled
Port 1b4dcc3 to glitch-soc

Signed-off-by: Thibaut Girka <thib@sitedethib.com>

@ThibG ThibG force-pushed the ThibG:glitch-soc/features/single-column branch from 77e4642 to 3578537 Jun 13, 2019

@ThibG ThibG merged commit 8084981 into glitch-soc:master Jun 13, 2019

10 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.