Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options to highlight misleading links in statuses text #1185

Merged

Conversation

@ThibG
Copy link

commented Aug 1, 2019

This adds a bunch of options to fix #1162

What it does not attempt to do

  • Extract any information from the target (that is, it does not help with link shorteners and other redirects)
  • Help in any way with spotting homograph attacks on International Domain Names
  • Warn against any list of known phishing or other malicious URLs

Link tagging options

image

Disabled

Present the statuses unmodified (besides basic server-side sanitizing), as is currently done.

image

Enabled

Add a colorful tag besides any link which does not match its target domain, without rewriting the link text itself. This is the default in this PR.

image

@ThibG ThibG force-pushed the ThibG:glitch-soc/features/disclose-link-target branch from f73c2a5 to d7c7e73 Aug 1, 2019

Perform case-insensitive comparison for international domain names
Note: this uses `toLowerCase()` instead of doing proper case folding

@ThibG ThibG force-pushed the ThibG:glitch-soc/features/disclose-link-target branch from 3cf446f to 7b035fb Aug 1, 2019

@ThibG

This comment has been minimized.

Copy link
Author

commented Aug 1, 2019

Updated by:

  • Making the tags just a bit smaller than normal text so that they stand out regardless of color
  • Removing the option to do as upstream, see tootsuite#11464

@ThibG ThibG force-pushed the ThibG:glitch-soc/features/disclose-link-target branch from 7b035fb to 88c0780 Aug 1, 2019

@ThibG ThibG merged commit ff0ceb2 into glitch-soc:master Aug 4, 2019

10 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.