New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial work on user-controlled multi-column/single-column overrides #26

Merged
merged 8 commits into from Jun 25, 2017

Conversation

Projects
None yet
2 participants
@ekiru

ekiru commented Jun 24, 2017

This lets us override the automatic resizing and most other screen/window size-based styling and UI changes with a CSS class so that users can choose to use the single-column layout on wider screens or the multi-column one on narrow screens.

Currently which setting to use (force single-column, force multi-column, or automatically determine based on width (as before)) is hardcoded in the UI component as a columns constant. @marrus-sh said they'd add a button to allow users to actually control it, so sending this PR so that they can do so. :)

It shouldn't be terribly hard to merge stylesheet changes from upstream; the only differences there are defining two mixins for media queries that should pass in force-single-column mode and media queries that should pass in force-multi-column mode that does some futzing around to make that override work while preserving the autodetection behavior in auto mode, and replacing most media queries in the web client with whichever of those is appropriate. I left out admin/about page styles since they don't have the same layout situation anyway, as well as about three or four media queries in the main web client that don't look like they affect the layout. Even the indents are unchanged :)

@marrus-sh marrus-sh merged commit e4326b3 into glitch-soc:master Jun 25, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment