This repository has been archived by the owner. It is now read-only.

Start to make homepage responsive ( addresses #180 ) #108

Merged
merged 2 commits into from Oct 25, 2013

Conversation

Projects
None yet
3 participants
@misjoinder
Contributor

misjoinder commented Oct 25, 2013

Minor changes to:

  • add build files to .gitignore
  • improve mobile view of homepage with CSS media queries
  • fix minor typo on not-using-Tor alert message (required change to translations.js, too)
@fpietrosanti

This comment has been minimized.

Show comment
Hide comment
@fpietrosanti

fpietrosanti Oct 25, 2013

Contributor

Wow! Thanks! Do you have any other suggestion or improvement to make GLClient better? @vecna and @evilaliv3 are going to further work on it in upcoming weeks, so a cooperation would be on perfect timing! :)

Contributor

fpietrosanti commented Oct 25, 2013

Wow! Thanks! Do you have any other suggestion or improvement to make GLClient better? @vecna and @evilaliv3 are going to further work on it in upcoming weeks, so a cooperation would be on perfect timing! :)

@evilaliv3

This comment has been minimized.

Show comment
Hide comment
@evilaliv3

evilaliv3 Oct 25, 2013

Contributor

very good fix :) thank you @msjoinder

Contributor

evilaliv3 commented Oct 25, 2013

very good fix :) thank you @msjoinder

evilaliv3 added a commit that referenced this pull request Oct 25, 2013

Merge pull request #108 from msjoinder/mobile-responsive
Start to make homepage responsive ( addresses #180 )

@evilaliv3 evilaliv3 merged commit 28dc869 into globaleaks:master Oct 25, 2013

1 check passed

default The Travis CI build passed
Details
@misjoinder

This comment has been minimized.

Show comment
Hide comment
@misjoinder

misjoinder Oct 26, 2013

Contributor

@fpietrosanti thanks! I'd be interested in looking into more mobile and general CSS for the site

I'm actually running into an issue in my local version where the translate tags are still there in the /build version. How do I set my language? Do I need to have GLBackend running?

Contributor

misjoinder commented Oct 26, 2013

@fpietrosanti thanks! I'd be interested in looking into more mobile and general CSS for the site

I'm actually running into an issue in my local version where the translate tags are still there in the /build version. How do I set my language? Do I need to have GLBackend running?

@fpietrosanti

This comment has been minimized.

Show comment
Hide comment
@fpietrosanti

fpietrosanti Oct 26, 2013

Contributor

@msjoinder yes, you need also GLBackend because it report which are the supported languages in /node and the GLC act accordinly. @evilaliv3 is more knowledgable about this methods.
Are you on irc and/or jabber?
I saw also your securedrop contribution. Are you going to work on some comparison of the two, as i made a spreadsheet about it?

Contributor

fpietrosanti commented Oct 26, 2013

@msjoinder yes, you need also GLBackend because it report which are the supported languages in /node and the GLC act accordinly. @evilaliv3 is more knowledgable about this methods.
Are you on irc and/or jabber?
I saw also your securedrop contribution. Are you going to work on some comparison of the two, as i made a spreadsheet about it?

@misjoinder

This comment has been minimized.

Show comment
Hide comment
@misjoinder

misjoinder Oct 28, 2013

Contributor

I had issues installing things, but then I installed them inside virtualenv. Now it's working (though I wasn't able to sign in as admin)

I noticed a couple of issues with the CSS in my pull request. The You Are Not Secure message, for example, still goes outside the window because the .informationBox CSS gets overwritten. I'll submit another pull request once I get a chance to go through and make more parts of the site mobile-responsive.

Contributor

misjoinder commented Oct 28, 2013

I had issues installing things, but then I installed them inside virtualenv. Now it's working (though I wasn't able to sign in as admin)

I noticed a couple of issues with the CSS in my pull request. The You Are Not Secure message, for example, still goes outside the window because the .informationBox CSS gets overwritten. I'll submit another pull request once I get a chance to go through and make more parts of the site mobile-responsive.

@fpietrosanti

This comment has been minimized.

Show comment
Hide comment
@fpietrosanti

fpietrosanti Oct 28, 2013

Contributor

@msjoinder Making the whoole globaleaks working on an Android and iPhone phone's screen would be a wonderful achievement. Please also open up tickets related to UX/Usability improvement that you consider useful

Contributor

fpietrosanti commented Oct 28, 2013

@msjoinder Making the whoole globaleaks working on an Android and iPhone phone's screen would be a wonderful achievement. Please also open up tickets related to UX/Usability improvement that you consider useful

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.