New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Currency parsing #364

Open
rxaviers opened this Issue Dec 10, 2014 · 3 comments

Comments

Projects
None yet
2 participants
@rxaviers
Member

rxaviers commented Dec 10, 2014

Implement currency parsing

Ref #238

Depends on:

@rxaviers rxaviers added this to the 1.0.0 milestone Dec 10, 2014

@rxaviers rxaviers modified the milestones: 1.1.0, 1.0.0 Feb 12, 2015

@rxaviers rxaviers added new feature and removed new feature labels Oct 11, 2015

@rxaviers rxaviers modified the milestone: 1.1.0 Oct 11, 2015

@rxaviers rxaviers referenced this issue Oct 12, 2015

Open

Improve roadmap visibility #474

3 of 3 tasks complete
@goatandsheep

This comment has been minimized.

Show comment
Hide comment
@goatandsheep

goatandsheep Dec 22, 2017

Contributor

Until this feature is launched, please remove the "and parsing" from "Currency module provides currency formatting and parsing" on the README. It's extremely misleading.

Contributor

goatandsheep commented Dec 22, 2017

Until this feature is launched, please remove the "and parsing" from "Currency module provides currency formatting and parsing" on the README. It's extremely misleading.

@rxaviers

This comment has been minimized.

Show comment
Hide comment
@rxaviers

rxaviers Dec 22, 2017

Member

True, it might have been a typo, would you like to submit a fix PR? Thanks for spotting it!

Member

rxaviers commented Dec 22, 2017

True, it might have been a typo, would you like to submit a fix PR? Thanks for spotting it!

rxaviers added a commit that referenced this issue Dec 27, 2017

Docs: No currency parsing yet
Updated readme to reflect current state of [currency parsing
ticket](#364)

Closes #793
Ref #364
@goatandsheep

This comment has been minimized.

Show comment
Hide comment
@goatandsheep

goatandsheep Dec 28, 2017

Contributor

I have an idea, actually. What if we:

  1. Parse the currency string for numbers, commas, and periods: valueString.replace(/[^\d\.\,]/g, '')
  2. Run numberParser

Currency codes define the symbols and locale defines the number format. If we're just parsing the number, we can strip away the symbols and parse the number in the locale specified in the settings

Contributor

goatandsheep commented Dec 28, 2017

I have an idea, actually. What if we:

  1. Parse the currency string for numbers, commas, and periods: valueString.replace(/[^\d\.\,]/g, '')
  2. Run numberParser

Currency codes define the symbols and locale defines the number format. If we're just parsing the number, we can strip away the symbols and parse the number in the locale specified in the settings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment