Fixes #487 #555

Closed
wants to merge 5 commits into
from

Conversation

Projects
None yet
5 participants
@karan1276
Contributor

karan1276 commented Nov 19, 2015

Fixes #487:

I have used this grunt plugin to create AUTHORS.txt

update-authors task has been registered as the last default task.

Note that i have not made any modification to grunt-git-authors plugin, grunt runs default update-authors task.
QueryUi has created a custom update-authors task here ,on demand i can write a custom update-authors task as well.

i may have messed something up 馃槄 , let me know if something is to be corrected.

Thank You

AUTHORS.txt
+Richard Worth <rdworth@gmail.com>
+Richard D. Worth <rdworth@gmail.com>
+J枚rn Zaefferer <joern.zaefferer@gmail.com>
+Jo虉rn Zaefferer <joern.zaefferer@gmail.com>

This comment has been minimized.

@jzaefferer

jzaefferer Nov 19, 2015

Contributor

Needs a .mailmap (like https://github.com/jquery/jquery-ui/blob/master/.mailmap#L57 ) to remove the duplicate entries. At least for me and Richard (above), there might be more.

@jzaefferer

jzaefferer Nov 19, 2015

Contributor

Needs a .mailmap (like https://github.com/jquery/jquery-ui/blob/master/.mailmap#L57 ) to remove the duplicate entries. At least for me and Richard (above), there might be more.

This comment has been minimized.

@rxaviers

rxaviers Nov 19, 2015

Member

@jzaefferer what's the process of creating this map file? Manually checking for duplicates in AUTHORS.txt?

@rxaviers

rxaviers Nov 19, 2015

Member

@jzaefferer what's the process of creating this map file? Manually checking for duplicates in AUTHORS.txt?

This comment has been minimized.

@jzaefferer

jzaefferer Nov 19, 2015

Contributor

Yeah, manually checking for duplicates and adding appropriate entries to .mailmap.

@jzaefferer

jzaefferer Nov 19, 2015

Contributor

Yeah, manually checking for duplicates and adding appropriate entries to .mailmap.

Gruntfile.js
@@ -654,7 +654,8 @@ module.exports = function( grunt ) {
"test:functional",
"uglify",
"compare_size",
- "commitplease"
+ "commitplease",
+ "update-authors"

This comment has been minimized.

@jzaefferer

jzaefferer Nov 19, 2015

Contributor

Bad indent

@jzaefferer

jzaefferer Nov 19, 2015

Contributor

Bad indent

This comment has been minimized.

@karan1276

karan1276 Nov 19, 2015

Contributor

@jzaefferer i don't know why but the indentation appeared correctly on my text editor (Adobe Brackets), however i thought it was a editor bug and added a tab.

After adding a tab indentation looks correct at github diff here but continuous-integration/travis-ci/pr fails because of bad indentation.

@karan1276

karan1276 Nov 19, 2015

Contributor

@jzaefferer i don't know why but the indentation appeared correctly on my text editor (Adobe Brackets), however i thought it was a editor bug and added a tab.

After adding a tab indentation looks correct at github diff here but continuous-integration/travis-ci/pr fails because of bad indentation.

@karan1276

This comment has been minimized.

Show comment
Hide comment
@karan1276

karan1276 Nov 19, 2015

Contributor

Thanks @jzaefferer , i will make appropriate changes soon 馃槃

Contributor

karan1276 commented Nov 19, 2015

Thanks @jzaefferer , i will make appropriate changes soon 馃槃

Gruntfile.js:Auto generate AUTHORS.txt
Include 'grunt-git-authors' as devDependency, use 'update-author' task provided

by this plugin to auto generate AUTHORS.txt

Fixes #487
Gruntfile.js
@@ -654,7 +654,8 @@ module.exports = function( grunt ) {
"test:functional",
"uglify",
"compare_size",
- "commitplease"
+ "commitplease",
+ "update-authors"

This comment has been minimized.

@jzaefferer

jzaefferer Nov 19, 2015

Contributor

This is now a mix of spaces and tabs. Replace the 8 spaces at the start with 2 tabs, 3 tabs indent in total.

@jzaefferer

jzaefferer Nov 19, 2015

Contributor

This is now a mix of spaces and tabs. Replace the 8 spaces at the start with 2 tabs, 3 tabs indent in total.

karan1276 added some commits Nov 19, 2015

Gruntfile.js:Remove bad indent
Remove bad indent from gruntfile.js
.mailmap:Create .mailmap
Created .mailmap file to avoid duplicate entries in AUTHORS.txt

Ref #487
AUTHORS.txt:Create AUTHORS.txt
Create AUTHORS.txt that lists names and email ids of contributors of globalize

Ref #487

@karan1276 karan1276 referenced this pull request in jquery/api.jquery.com Nov 22, 2015

Closed

Fixes 659, Returning elements in DOM order is documented now #833

@karan1276

This comment has been minimized.

Show comment
Hide comment
@karan1276

karan1276 Nov 22, 2015

Contributor

I guess all issues regarding #478 are done, if i am missing something let me know. I will correct it asap 馃槃

Contributor

karan1276 commented Nov 22, 2015

I guess all issues regarding #478 are done, if i am missing something let me know. I will correct it asap 馃槃

@rxaviers

This comment has been minimized.

Show comment
Hide comment
@rxaviers

rxaviers Nov 22, 2015

Member

I'm letting @jzaefferer verify. :)

Member

rxaviers commented Nov 22, 2015

I'm letting @jzaefferer verify. :)

.mailmap
@@ -0,0 +1,2 @@
+J枚rn Zaefferer <joern.zaefferer@gmail.com>
+Richard D. Worth <rdworth@gmail.com>

This comment has been minimized.

@rxaviers

rxaviers Nov 22, 2015

Member

Needs newline.

@rxaviers

rxaviers Nov 22, 2015

Member

Needs newline.

This comment has been minimized.

@karan1276

karan1276 Nov 26, 2015

Contributor

@rxaviers i am sorry i didn't get you. Do you mean there should be a new line at the end (after "Richard D. Worth") ?

@karan1276

karan1276 Nov 26, 2015

Contributor

@rxaviers i am sorry i didn't get you. Do you mean there should be a new line at the end (after "Richard D. Worth") ?

This comment has been minimized.

@rxaviers

rxaviers Nov 26, 2015

Member

Usually this is something you configure in your text editor. See that red empty sign above? It means your file ends like this: "Richard D. Worth rdworth@gmail.comEOF" instead of "Richard D. Worth rdworth@gmail.com\nEOF".

@rxaviers

rxaviers Nov 26, 2015

Member

Usually this is something you configure in your text editor. See that red empty sign above? It means your file ends like this: "Richard D. Worth rdworth@gmail.comEOF" instead of "Richard D. Worth rdworth@gmail.com\nEOF".

This comment has been minimized.

@karan1276

karan1276 Nov 26, 2015

Contributor

Oh ok, i get what you mean but i can't see a red empty sign 馃樁 , anyways no issue, in my next commit i will end files with newline.

@karan1276

karan1276 Nov 26, 2015

Contributor

Oh ok, i get what you mean but i can't see a red empty sign 馃樁 , anyways no issue, in my next commit i will end files with newline.

This comment has been minimized.

@rxaviers

rxaviers Nov 26, 2015

Member

No problem. For clarity about the sign, that's what I was referring to:
screenshot from 2015-11-26 11-02-31

Thanks.

@rxaviers

rxaviers Nov 26, 2015

Member

No problem. For clarity about the sign, that's what I was referring to:
screenshot from 2015-11-26 11-02-31

Thanks.

This comment has been minimized.

@karan1276

karan1276 Nov 26, 2015

Contributor

@rxaviers I just figured out there is a rule for line feed in JCSC, if you allow i can report a new issue and add that rule to globalize's .jscsrc.

@karan1276

karan1276 Nov 26, 2015

Contributor

@rxaviers I just figured out there is a rule for line feed in JCSC, if you allow i can report a new issue and add that rule to globalize's .jscsrc.

This comment has been minimized.

@rxaviers

rxaviers Nov 26, 2015

Member

It definitely helps, thanks.

@rxaviers

rxaviers Nov 26, 2015

Member

It definitely helps, thanks.

This comment has been minimized.

@karan1276

karan1276 Nov 26, 2015

Contributor

It doesn't really matter now but why don't i get that red sign on my machine, any ideas?
screen shot 2015-11-26 at 6 59 24 pm

@karan1276

karan1276 Nov 26, 2015

Contributor

It doesn't really matter now but why don't i get that red sign on my machine, any ideas?
screen shot 2015-11-26 at 6 59 24 pm

This comment has been minimized.

@rxaviers

rxaviers Nov 26, 2015

Member

Oh, this is interesting... Either a github bug or something that is configurable? Sorry not being able to help here.

@rxaviers

rxaviers Nov 26, 2015

Member

Oh, this is interesting... Either a github bug or something that is configurable? Sorry not being able to help here.

@karan1276

This comment has been minimized.

Show comment
Hide comment
@karan1276

karan1276 Nov 22, 2015

Contributor

Sure :)
On 22-Nov-2015 10:50 PM, "Rafael Xavier de Souza" notifications@github.com
wrote:

I'm letting @jzaefferer https://github.com/jzaefferer verify. :)


Reply to this email directly or view it on GitHub
#555 (comment).

Contributor

karan1276 commented Nov 22, 2015

Sure :)
On 22-Nov-2015 10:50 PM, "Rafael Xavier de Souza" notifications@github.com
wrote:

I'm letting @jzaefferer https://github.com/jzaefferer verify. :)


Reply to this email directly or view it on GitHub
#555 (comment).

AUTHORS.txt
@@ -0,0 +1,50 @@
+Authors ordered by first contribution
+
+InfinitiesLoop <dareed@microsoft.com>

This comment has been minimized.

@scottgonzalez

scottgonzalez Nov 25, 2015

Contributor

Dave Reed

@scottgonzalez

scottgonzalez Nov 25, 2015

Contributor

Dave Reed

AUTHORS.txt
+Authors ordered by first contribution
+
+InfinitiesLoop <dareed@microsoft.com>
+.NET jQuery Extensions <Swalther@Microsoft.com>

This comment has been minimized.

@scottgonzalez

scottgonzalez Nov 25, 2015

Contributor

Stephen Walther

@scottgonzalez

scottgonzalez Nov 25, 2015

Contributor

Stephen Walther

AUTHORS.txt
+InfinitiesLoop <dareed@microsoft.com>
+.NET jQuery Extensions <Swalther@Microsoft.com>
+Tobie Langel <tobie.langel@gmail.com>
+jeresig <jeresig@gmail.com>

This comment has been minimized.

@scottgonzalez

scottgonzalez Nov 25, 2015

Contributor

John Resig

@scottgonzalez

scottgonzalez Nov 25, 2015

Contributor

John Resig

AUTHORS.txt
+Eric Br茅chemier <legalbox@eric.brechemier.name>
+Nikolaus Graf <nik@deck.cc>
+J枚rn Zaefferer <joern.zaefferer@gmail.com>
+BorisMoore <BorisMoore@gmail.com>

This comment has been minimized.

@scottgonzalez

scottgonzalez Nov 25, 2015

Contributor

Boris Moore

@scottgonzalez

scottgonzalez Nov 25, 2015

Contributor

Boris Moore

AUTHORS.txt
+Kyle Florence <kyle.florence@gmail.com>
+David De Sloovere <david.desloovere@hotmail.com>
+Christian Vuerings <vueringschristian@gmail.com>
+blq <fblomqvist@gmail.com>

This comment has been minimized.

@scottgonzalez

scottgonzalez Nov 25, 2015

Contributor

Fredrik Blomqvist

@scottgonzalez

scottgonzalez Nov 25, 2015

Contributor

Fredrik Blomqvist

AUTHORS.txt
+Scott Gonz谩lez <scott.gonzalez@gmail.com>
+Nick Schonning <nschonni@gmail.com>
+Rafael Xavier de Souza <rxaviers@gmail.com>
+Blixt <me@blixt.org>

This comment has been minimized.

@scottgonzalez

scottgonzalez Nov 25, 2015

Contributor

Andreas Blixt

@scottgonzalez

scottgonzalez Nov 25, 2015

Contributor

Andreas Blixt

AUTHORS.txt
+Raphael Amorim <rapha850@gmail.com>
+Yasuhiro Yoshida <yasuhiro.yoppu@gmail.com>
+Anne-Gaelle Colom <coloma@westminster.ac.uk>
+RikeCreates <rikunieminen@gmail.com>

This comment has been minimized.

@scottgonzalez

scottgonzalez Nov 25, 2015

Contributor

Riku Nieminen

@scottgonzalez

scottgonzalez Nov 25, 2015

Contributor

Riku Nieminen

AUTHORS.txt
+Arvind Kalyan <arvchamp@gmail.com>
+Tobias Nie脽en <tniessen@tnie.de>
+Kevin Kirsche <Kev.Kirsche+GitHub@gmail.com>
+Ed S <ejsanders@gmail.com>

This comment has been minimized.

@scottgonzalez

scottgonzalez Nov 25, 2015

Contributor

Ed Sanders

@scottgonzalez

scottgonzalez Nov 25, 2015

Contributor

Ed Sanders

@scottgonzalez

This comment has been minimized.

Show comment
Hide comment
@scottgonzalez

scottgonzalez Nov 25, 2015

Contributor

I left a bunch of comments on the authors list that need mailmap entries.

Contributor

scottgonzalez commented Nov 25, 2015

I left a bunch of comments on the authors list that need mailmap entries.

@rxaviers

This comment has been minimized.

Show comment
Hide comment
@rxaviers

rxaviers Nov 25, 2015

Member

Thanks Scott.

Member

rxaviers commented Nov 25, 2015

Thanks Scott.

@karan1276

This comment has been minimized.

Show comment
Hide comment
@karan1276

karan1276 Nov 26, 2015

Contributor

@scottgonzalez i will make changes to .mailmap accordingly, thanks.

Contributor

karan1276 commented Nov 26, 2015

@scottgonzalez i will make changes to .mailmap accordingly, thanks.

.mailmap: Use formal names in AUTHORS.txt
Update .mailmap file to use formal names in AUTHORS.txt
@rxaviers

This comment has been minimized.

Show comment
Hide comment
@rxaviers

rxaviers Dec 2, 2015

Member

Hi @karan1276,

How is this PR going? Do you need any help?

Thanks

Member

rxaviers commented Dec 2, 2015

Hi @karan1276,

How is this PR going? Do you need any help?

Thanks

@karan1276

This comment has been minimized.

Show comment
Hide comment
@karan1276

karan1276 Dec 2, 2015

Contributor

Hey @rxaviers,
I think this PR resolves the issue it was intended to solve.
If i have missed something let me know :), all bugs pointed by contributors above have be patched.
I think this PR is ready to be pulled.
Thanks

Contributor

karan1276 commented Dec 2, 2015

Hey @rxaviers,
I think this PR resolves the issue it was intended to solve.
If i have missed something let me know :), all bugs pointed by contributors above have be patched.
I think this PR is ready to be pulled.
Thanks

@rxaviers

This comment has been minimized.

Show comment
Hide comment
@rxaviers

rxaviers Dec 2, 2015

Member

Excellent, will do a final review and let you know. Thank you!

Member

rxaviers commented Dec 2, 2015

Excellent, will do a final review and let you know. Thank you!

@karan1276

This comment has been minimized.

Show comment
Hide comment
@karan1276

karan1276 Dec 2, 2015

Contributor

Sure 馃憤

Contributor

karan1276 commented Dec 2, 2015

Sure 馃憤

@rxaviers rxaviers closed this in 71960b6 Dec 3, 2015

rxaviers added a commit that referenced this pull request Dec 3, 2015

rxaviers added a commit that referenced this pull request Dec 3, 2015

@rxaviers

This comment has been minimized.

Show comment
Hide comment
@rxaviers

rxaviers Dec 3, 2015

Member

Excellent, landed. Thank you @karan1276 .

Member

rxaviers commented Dec 3, 2015

Excellent, landed. Thank you @karan1276 .

@karan1276

This comment has been minimized.

Show comment
Hide comment
@karan1276

karan1276 Dec 3, 2015

Contributor

Thanks @rxaviers, i am glad i could help 馃槉

Contributor

karan1276 commented Dec 3, 2015

Thanks @rxaviers, i am glad i could help 馃槉

rxaviers added a commit that referenced this pull request Dec 3, 2015

@rxaviers

This comment has been minimized.

Show comment
Hide comment
@rxaviers

rxaviers Dec 3, 2015

Member

馃憤 your help is very welcome.

Member

rxaviers commented Dec 3, 2015

馃憤 your help is very welcome.

rxaviers added a commit that referenced this pull request Dec 5, 2015

rxaviers added a commit that referenced this pull request Jan 17, 2016

Build: Auto generate AUTHORS.txt
- Include 'grunt-git-authors' as devDependency, use 'update-author' task
  provided by this plugin to auto generate AUTHORS.txt.
- Created .mailmap file to avoid duplicate entries in AUTHORS.txt.

Fixes #487
Closes #555

rxaviers added a commit that referenced this pull request Jan 17, 2016

rxaviers added a commit that referenced this pull request Jan 17, 2016

rxaviers added a commit that referenced this pull request Jan 17, 2016

rxaviers added a commit that referenced this pull request Jan 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment