Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
DateTimeFormatter: Dynamically augment skeleton #604
I have implemented another skeleton pattern comparison algorithm, which fixes a lot of issues I have found in #462 implementation.
But not all resulst same from Flex Test and my implementation. This is difference table:
And all other differences are similar. In fact, I am really can not understand, why flexTest augments
Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA).
After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know.
If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check.
changed the title from
Dynamically augment skeleton
DateTimeFormatter: Dynamically augment skeleton
Apr 3, 2016
added a commit
this pull request
Apr 3, 2016
@rxaviers My algorithm is close to http://www.unicode.org/reports/tr35/tr35-dates.html#Matching_Skeletons, but seems with several bugs in it. I do not handle rule "Numeric and text fields are given a larger distance from each other. MMM ≈ MM"
I'll work on it but later (next week I suppose)
referenced this pull request
Apr 4, 2016
Also check/benchmark these ecma-402 polyfil implementations, can we reuse the idea/algo?