New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LICENSE: Add MIT header #780

Merged
merged 2 commits into from Oct 17, 2017

Conversation

Projects
None yet
3 participants
@rxaviers
Member

rxaviers commented Oct 17, 2017

@scottgonzalez @kborchers please can you confirm this update is ok? Thanks

@kborchers

This comment has been minimized.

Show comment
Hide comment
@kborchers

kborchers Oct 17, 2017

Contributor

Not sure how we missed this before but the copyright line needs to be updated to

Copyright JS Foundation and other contributors, https://js.foundation

Otherwise the addition of the MIT header LGTM

Contributor

kborchers commented Oct 17, 2017

Not sure how we missed this before but the copyright line needs to be updated to

Copyright JS Foundation and other contributors, https://js.foundation

Otherwise the addition of the MIT header LGTM

@rxaviers

This comment has been minimized.

Show comment
Hide comment
@rxaviers

rxaviers Oct 17, 2017

Member

Copyright JS Foundation and other contributors, https://js.foundation

Updated in https://github.com/rxaviers/globalize/tree/license-mit, though it seems like github hasn't synced my updates in this PR yet (weird, never saw that before)

Member

rxaviers commented Oct 17, 2017

Copyright JS Foundation and other contributors, https://js.foundation

Updated in https://github.com/rxaviers/globalize/tree/license-mit, though it seems like github hasn't synced my updates in this PR yet (weird, never saw that before)

@kborchers

This comment has been minimized.

Show comment
Hide comment
@kborchers

kborchers Oct 17, 2017

Contributor

Wow, that is very strange 😕

Contributor

kborchers commented Oct 17, 2017

Wow, that is very strange 😕

@rxaviers

This comment has been minimized.

Show comment
Hide comment
@rxaviers

rxaviers Oct 17, 2017

Member

There we go, now it's synced.

Member

rxaviers commented Oct 17, 2017

There we go, now it's synced.

@rxaviers rxaviers merged commit d5c9c04 into globalizejs:master Oct 17, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@scottgonzalez

This comment has been minimized.

Show comment
Hide comment
@scottgonzalez

scottgonzalez Oct 17, 2017

Contributor

I know this was already merged, but since I was tagged, I figured I'd still leave my feedback.

I personally avoid doing this type of labeling because we've gone through the effort of informing users that even though this package itself is released under the terms of the MIT license, it has portions of its own code, as well as dependencies, that are released under different licenses. If you want to include the heading of "The MIT License (MIT)", I would suggest adding that on L14 rather than L1.

Contributor

scottgonzalez commented Oct 17, 2017

I know this was already merged, but since I was tagged, I figured I'd still leave my feedback.

I personally avoid doing this type of labeling because we've gone through the effort of informing users that even though this package itself is released under the terms of the MIT license, it has portions of its own code, as well as dependencies, that are released under different licenses. If you want to include the heading of "The MIT License (MIT)", I would suggest adding that on L14 rather than L1.

rxaviers added a commit to rxaviers/globalize that referenced this pull request Oct 17, 2017

@rxaviers

This comment has been minimized.

Show comment
Hide comment
@rxaviers

rxaviers Oct 17, 2017

Member

Makes sense Scott, I'm pushing an amend commit soon.

Member

rxaviers commented Oct 17, 2017

Makes sense Scott, I'm pushing an amend commit soon.

@rxaviers

This comment has been minimized.

Show comment
Hide comment
@rxaviers

rxaviers Oct 17, 2017

Member

Updated in d01e049

Member

rxaviers commented Oct 17, 2017

Updated in d01e049

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment